2023-04-05 05:50:53

by Christoph Hellwig

[permalink] [raw]
Subject: remove crc32c_impl

Hi all,

this series stops printing the crc32c implementation at btrfs load
time as it's already printed at mount time, and then removes the
now unused crc32c_impl function.

This series is on top of the btrfs for-next tree, which has a bunch
of required crc32c-related work.

Diffstat:
fs/btrfs/super.c | 2 +-
include/linux/crc32c.h | 1 -
lib/libcrc32c.c | 6 ------
3 files changed, 1 insertion(+), 8 deletions(-)


2023-04-05 05:50:56

by Christoph Hellwig

[permalink] [raw]
Subject: [PATCH 1/2] btrfs: don't print the crc32c implementtion at load time

Btrfs can use various different checksumming algorithms, and prints
the one used for a given file system at mount time. Don't bother
printing the crc32c implementation at module load time.

Signed-off-by: Christoph Hellwig <[email protected]>
---
fs/btrfs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 285c7189b92466..bf79e49157c5e5 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -2412,7 +2412,7 @@ static int __init btrfs_print_mod_info(void)
", fsverity=no"
#endif
;
- pr_info("Btrfs loaded, crc32c=%s%s\n", crc32c_impl(), options);
+ pr_info("Btrfs loaded%s\n", options);
return 0;
}

--
2.39.2

2023-04-05 14:11:52

by David Sterba

[permalink] [raw]
Subject: Re: remove crc32c_impl

On Wed, Apr 05, 2023 at 07:49:03AM +0200, Christoph Hellwig wrote:
> Hi all,
>
> this series stops printing the crc32c implementation at btrfs load
> time as it's already printed at mount time, and then removes the
> now unused crc32c_impl function.

Added to misc-next, with Herbert's ack, thanks.