2020-02-26 17:15:46

by Zi Yan

[permalink] [raw]
Subject: Re: [PATCH v8 07/25] mm: Rename various 'offset' parameters to 'index'

On 25 Feb 2020, at 16:48, Matthew Wilcox wrote:

> From: "Matthew Wilcox (Oracle)" <[email protected]>
>
> The word 'offset' is used ambiguously to mean 'byte offset within
> a page', 'byte offset from the start of the file' and 'page offset
> from the start of the file'. Use 'index' to mean 'page offset
> from the start of the file' throughout the readahead code.
>
> Signed-off-by: Matthew Wilcox (Oracle) <[email protected]>

Looks good to me.

Reviewed-by: Zi Yan <[email protected]>


Best Regards,
Yan Zi


Attachments:
signature.asc (871.00 B)
OpenPGP digital signature