2011-05-14 07:05:06

by Yongqiang Yang

Subject: [PATCH] ext4:Make ext4_split_extent() handle error correctly.

Signed-off-by: Yongqiang Yang <[email protected]>
---
fs/ext4/extents.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index e363f21..b7b667f 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2716,6 +2716,8 @@ static int ext4_split_extent(handle_t *handle,
EXT4_EXT_MARK_UNINIT2;
err = ext4_split_extent_at(handle, inode, path,
map->m_lblk + map->m_len, split_flag1, flags1);
+ if (err)
+ goto out;
}

ext4_ext_drop_refs(path);
--
1.7.5.1

--

2011-05-16 15:08:37

by Mingming Cao

Subject: Re: [PATCH] ext4:Make ext4_split_extent() handle error correctly.

On Sat, 2011-05-14 at 15:05 +0800, Yongqiang Yang wrote:
> Signed-off-by: Yongqiang Yang <[email protected]>

Reviewed-by: Mingming Cao <[email protected]>
> ---
> fs/ext4/extents.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index e363f21..b7b667f 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -2716,6 +2716,8 @@ static int ext4_split_extent(handle_t *handle,
> EXT4_EXT_MARK_UNINIT2;
> err = ext4_split_extent_at(handle, inode, path,
> map->m_lblk + map->m_len, split_flag1, flags1);
> + if (err)
> + goto out;
> }
>
> ext4_ext_drop_refs(path);

2011-05-23 00:51:42

by Theodore Ts'o

Subject: Re: [PATCH] ext4:Make ext4_split_extent() handle error correctly.

Added to the ext4 tree, thanks.

- Ted

On Sat, May 14, 2011 at 03:05:05PM +0800, Yongqiang Yang wrote:
> Signed-off-by: Yongqiang Yang <[email protected]>
> ---
> fs/ext4/extents.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index e363f21..b7b667f 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -2716,6 +2716,8 @@ static int ext4_split_extent(handle_t *handle,
> EXT4_EXT_MARK_UNINIT2;
> err = ext4_split_extent_at(handle, inode, path,
> map->m_lblk + map->m_len, split_flag1, flags1);
> + if (err)
> + goto out;
> }
>
> ext4_ext_drop_refs(path);
> --
> 1.7.5.1
>
> --