2016-09-14 19:27:59

by Eric Biggers

[permalink] [raw]
Subject: [PATCH] blockgroup_lock.h: remove debris from bgl_lock_ptr() conversion

An obsolete comment and extra parentheses were left over from when the
sb_bgl_lock() macro was replaced with the bgl_lock_ptr() function.

Signed-off-by: Eric Biggers <[email protected]>
---
include/linux/blockgroup_lock.h | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/include/linux/blockgroup_lock.h b/include/linux/blockgroup_lock.h
index e44b88b..61b583d 100644
--- a/include/linux/blockgroup_lock.h
+++ b/include/linux/blockgroup_lock.h
@@ -49,14 +49,10 @@ static inline void bgl_lock_init(struct blockgroup_lock *bgl)
spin_lock_init(&bgl->locks[i].lock);
}

-/*
- * The accessor is a macro so we can embed a blockgroup_lock into different
- * superblock types
- */
static inline spinlock_t *
bgl_lock_ptr(struct blockgroup_lock *bgl, unsigned int block_group)
{
- return &bgl->locks[(block_group) & (NR_BG_LOCKS-1)].lock;
+ return &bgl->locks[block_group & (NR_BG_LOCKS-1)].lock;
}

#endif
--
2.8.0.rc3.226.g39d4020


2016-09-14 21:09:04

by Andreas Dilger

[permalink] [raw]
Subject: Re: [PATCH] blockgroup_lock.h: remove debris from bgl_lock_ptr() conversion

On Sep 14, 2016, at 1:27 PM, Eric Biggers <[email protected]> wrote:
>
> An obsolete comment and extra parentheses were left over from when the
> sb_bgl_lock() macro was replaced with the bgl_lock_ptr() function.
>
> Signed-off-by: Eric Biggers <[email protected]>

Reviewed-by: Andreas Dilger <[email protected]>

> ---
> include/linux/blockgroup_lock.h | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/include/linux/blockgroup_lock.h b/include/linux/blockgroup_lock.h
> index e44b88b..61b583d 100644
> --- a/include/linux/blockgroup_lock.h
> +++ b/include/linux/blockgroup_lock.h
> @@ -49,14 +49,10 @@ static inline void bgl_lock_init(struct blockgroup_lock *bgl)
> spin_lock_init(&bgl->locks[i].lock);
> }
>
> -/*
> - * The accessor is a macro so we can embed a blockgroup_lock into different
> - * superblock types
> - */
> static inline spinlock_t *
> bgl_lock_ptr(struct blockgroup_lock *bgl, unsigned int block_group)
> {
> - return &bgl->locks[(block_group) & (NR_BG_LOCKS-1)].lock;
> + return &bgl->locks[block_group & (NR_BG_LOCKS-1)].lock;
> }
>
> #endif
> --
> 2.8.0.rc3.226.g39d4020
>


Cheers, Andreas





Attachments:
signature.asc (833.00 B)
Message signed with OpenPGP using GPGMail

2016-09-15 22:24:51

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [PATCH] blockgroup_lock.h: remove debris from bgl_lock_ptr() conversion

On Wed, Sep 14, 2016 at 12:27:59PM -0700, Eric Biggers wrote:
> An obsolete comment and extra parentheses were left over from when the
> sb_bgl_lock() macro was replaced with the bgl_lock_ptr() function.
>
> Signed-off-by: Eric Biggers <[email protected]>

Applied, thanks.

- Ted