2021-04-29 10:17:44

by Jiapeng Chong

Subject: [PATCH] ext4: Remove redundant assignment to error

Variable error is set to zero but this value is never read as it's not
used later on, hence it is a redundant assignment and can be removed.

Cleans up the following clang-analyzer warning:

fs/ext4/ioctl.c:657:3: warning: Value stored to 'error' is never read
[clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
fs/ext4/ioctl.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index e9b0a1f..796dcee 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -654,7 +654,6 @@ static int ext4_ioc_getfsmap(struct super_block *sb,
info.gi_data = arg;
error = ext4_getfsmap(sb, &xhead, ext4_getfsmap_format, &info);
if (error == EXT4_QUERY_RANGE_ABORT) {
- error = 0;
aborted = true;
} else if (error)
return error;
--
1.8.3.1

2021-06-17 02:35:59

by Theodore Ts'o

Subject: Re: [PATCH] ext4: Remove redundant assignment to error

On Thu, Apr 29, 2021 at 06:16:49PM +0800, Jiapeng Chong wrote:
> Variable error is set to zero but this value is never read as it's not
> used later on, hence it is a redundant assignment and can be removed.
>
> Cleans up the following clang-analyzer warning:
>
> fs/ext4/ioctl.c:657:3: warning: Value stored to 'error' is never read
> [clang-analyzer-deadcode.DeadStores].
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Applied, thanks.

- Ted