2021-10-26 01:57:54

by Nghia Le

Subject: [PATCH] ext4: remove useless resetting io_end_size in mpage_process_page()

The command "make clang-analyzer" detects dead stores in
mpage_process_page() function.

Do not reset io_end_size to 0 in the current paths, as the function
exits on those paths without further using io_end_size.

Signed-off-by: Nghia Le <[email protected]>
---
fs/ext4/inode.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 0f06305167d5..03efed2ed1ea 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2260,7 +2260,6 @@ static int mpage_process_page(struct mpage_da_data *mpd, struct page *page,
mpd->map.m_len = 0;
mpd->map.m_flags = 0;
io_end_vec->size += io_end_size;
- io_end_size = 0;

err = mpage_process_page_bufs(mpd, head, bh, lblk);
if (err > 0)
@@ -2285,7 +2284,6 @@ static int mpage_process_page(struct mpage_da_data *mpd, struct page *page,
} while (lblk++, (bh = bh->b_this_page) != head);

io_end_vec->size += io_end_size;
- io_end_size = 0;
*map_bh = false;
out:
*m_lblk = lblk;
--
2.25.1

2022-01-05 23:39:58

by Theodore Ts'o

Subject: Re: [PATCH] ext4: remove useless resetting io_end_size in mpage_process_page()

On Tue, 26 Oct 2021 05:18:03 +0700, Nghia Le wrote:
> The command "make clang-analyzer" detects dead stores in
> mpage_process_page() function.
>
> Do not reset io_end_size to 0 in the current paths, as the function
> exits on those paths without further using io_end_size.
>
>
> [...]

Applied, thanks!

[1/1] ext4: remove useless resetting io_end_size in mpage_process_page()
commit: 2e1a1101de1e37c80c750c2657cc35d7f560756c

Best regards,
--
Theodore Ts'o <[email protected]>