2022-09-18 12:24:43

by Guoqing Jiang

Subject: [PATCH] ext4: remove redundant checking in ext4_ioctl_checkpoint

It is already checked after comment "check for invalid bits set",
so let's remove this one.

Signed-off-by: Guoqing Jiang <[email protected]>
---
fs/ext4/ioctl.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index 3cf3ec4b1c21..80678af1fa7c 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -1060,9 +1060,6 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg)
if (!EXT4_SB(sb)->s_journal)
return -ENODEV;

- if (flags & ~EXT4_IOC_CHECKPOINT_FLAG_VALID)
- return -EINVAL;
-
if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) &&
!bdev_max_discard_sectors(EXT4_SB(sb)->s_journal->j_dev))
return -EOPNOTSUPP;
--
2.31.1

2022-09-30 03:21:40

by Theodore Ts'o

Subject: Re: [PATCH] ext4: remove redundant checking in ext4_ioctl_checkpoint

On Sun, 18 Sep 2022 19:52:19 +0800, Guoqing Jiang wrote:
> It is already checked after comment "check for invalid bits set",
> so let's remove this one.
>
>

Applied, thanks!

[1/1] ext4: remove redundant checking in ext4_ioctl_checkpoint
commit: 0a13172182a4d896bddfb42c06c85199fc526104

Best regards,
--
Theodore Ts'o <[email protected]>