2006-12-08 06:17:04

by Randy Dunlap

Subject: [PATCH] ext4 calls journal_stop

From: Randy Dunlap <[email protected]>

journal_stop() is not defined for ext4; change to ext4_journal_stop().

Signed-off-by: Randy Dunlap <[email protected]>
---
fs/ext4/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.19-git11.orig/fs/ext4/inode.c
+++ linux-2.6.19-git11/fs/ext4/inode.c
@@ -1232,7 +1232,7 @@ retry:
from, to, NULL, do_journal_get_write_access);
if (ret)
/* fatal error, just put the handle and return */
- journal_stop(handle);
+ ext4_journal_stop(handle);
}
return ret;



---

2006-12-08 08:14:19

by Andrew Morton

Subject: Re: [PATCH] ext4 calls journal_stop

On Thu, 7 Dec 2006 22:17:41 -0800
Randy Dunlap <[email protected]> wrote:

> From: Randy Dunlap <[email protected]>
>
> journal_stop() is not defined for ext4; change to ext4_journal_stop().
>
> Signed-off-by: Randy Dunlap <[email protected]>
> ---
> fs/ext4/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.19-git11.orig/fs/ext4/inode.c
> +++ linux-2.6.19-git11/fs/ext4/inode.c
> @@ -1232,7 +1232,7 @@ retry:
> from, to, NULL, do_journal_get_write_access);
> if (ret)
> /* fatal error, just put the handle and return */
> - journal_stop(handle);
> + ext4_journal_stop(handle);

rofl. That'll link and run if both filesystems are built. I bet it
doesn't run very well though