2007-12-12 21:45:41

by Mariusz Kozlowski

Subject: [PATCH -mm] ext4: remove unused code from ext4_find_entry()

Hello,

The unused code found in ext3_find_entry() is also present (and still unused)
in the ext4_find_entry() code. This patch removes it. Compile tested only.

Signed-off-by: Mariusz Kozlowski <[email protected]>

fs/ext4/namei.c | 68044 -> 67947 (-97 bytes)
fs/ext4/namei.o | 183840 -> 183792 (-48 bytes)

fs/ext4/namei.c | 4 ----
1 file changed, 4 deletions(-)

--- linux-2.6.24-rc4-mm1-a/fs/ext4/namei.c 2007-12-06 09:27:07.000000000 +0100
+++ linux-2.6.24-rc4-mm1-b/fs/ext4/namei.c 2007-12-12 22:32:45.000000000 +0100
@@ -861,14 +861,10 @@ static struct buffer_head * ext4_find_en
int i, err;
struct inode *dir = dentry->d_parent->d_inode;
int namelen;
- const u8 *name;
- unsigned blocksize;

*res_dir = NULL;
sb = dir->i_sb;
- blocksize = sb->s_blocksize;
namelen = dentry->d_name.len;
- name = dentry->d_name.name;
if (namelen > EXT4_NAME_LEN)
return NULL;
if (is_dx(dir)) {

2007-12-14 01:03:46

by Theodore Ts'o

Subject: Re: [PATCH -mm] ext4: remove unused code from ext4_find_entry()

On Wed, Dec 12, 2007 at 10:46:40PM +0100, Mariusz Kozlowski wrote:
> Hello,
>
> The unused code found in ext3_find_entry() is also present (and still unused)
> in the ext4_find_entry() code. This patch removes it. Compile tested only.
>
> Signed-off-by: Mariusz Kozlowski <[email protected]>

Signed-off-by: "Theodore Ts'o" <[email protected]>

Thanks, this will be in the next ext4 patchset.

- Ted