2008-03-27 07:30:55

by Girish Shilamkar

Subject: Entries in feature_list[]

Hi,
In e2fsprogs/lib/e2p/feature.c
struct feature feature_list[] contains:
...
{ E2P_FEATURE_INCOMPAT, EXT3_FEATURE_INCOMPAT_EXTENTS,
"extents" },
{ E2P_FEATURE_INCOMPAT, EXT2_FEATURE_INCOMPAT_META_BG,
"meta_bg" }
{ E2P_FEATURE_INCOMPAT, EXT3_FEATURE_INCOMPAT_EXTENTS,
"extent" },
...

Is the { E2P_*, EXT3_*, "extent"} entry correct one, if yes, what is the purpose behind having two
{E2P_FEATURE_INCOMPAT, EXT3_FEATURE_INCOMPAT_EXTENTS, *} entries, unless we want "extent" to be
correct feature ?


Thanks,
Girish

2008-04-13 03:50:06

by Andreas Dilger

Subject: Re: Entries in feature_list[]

On Mar 27, 2008 13:10 +0530, Girish Shilamkar wrote:
> In e2fsprogs/lib/e2p/feature.c
> struct feature feature_list[] contains:
> ...
> { E2P_FEATURE_INCOMPAT, EXT3_FEATURE_INCOMPAT_EXTENTS,
> "extents" },
> { E2P_FEATURE_INCOMPAT, EXT2_FEATURE_INCOMPAT_META_BG,
> "meta_bg" }
> { E2P_FEATURE_INCOMPAT, EXT3_FEATURE_INCOMPAT_EXTENTS,
> "extent" },
> ...
>
> Is the { E2P_*, EXT3_*, "extent"} entry correct one, if yes, what is the purpose behind having two
> {E2P_FEATURE_INCOMPAT, EXT3_FEATURE_INCOMPAT_EXTENTS, *} entries, unless we want "extent" to be
> correct feature ?

This is probably a merge error, or maybe a convenice measure to allow both
"extent" and "extents"? We need something similar for "uninit_groups"
and the new "uninit_bg".

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.