2008-10-13 16:14:11

by Aneesh Kumar K.V

Subject: [PATCH] ext4: Free ext4_prealloc_space using kmem_cache_free

We should use kmem_cache_free to free memory allocated
via kmem_cache_alloc

Signed-off-by: Aneesh Kumar K.V <[email protected]>
---
fs/ext4/mballoc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 7d5f70c..e54e03d 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2569,7 +2569,7 @@ static void ext4_mb_cleanup_pa(struct ext4_group_info *grp)
pa = list_entry(cur, struct ext4_prealloc_space, pa_group_list);
list_del(&pa->pa_group_list);
count++;
- kfree(pa);
+ kmem_cache_free(ext4_pspace_cachep, pa);
}
if (count)
mb_debug("mballoc: %u PAs left\n", count);
--
1.6.0.2.526.g5c283

2008-10-13 16:41:48

by Theodore Ts'o

Subject: Re: [PATCH] ext4: Free ext4_prealloc_space using kmem_cache_free

On Mon, Oct 13, 2008 at 09:44:03PM +0530, Aneesh Kumar K.V wrote:
> We should use kmem_cache_free to free memory allocated
> via kmem_cache_alloc

Thanks, queued.

- Ted