2009-01-29 22:46:31

by Eric Sandeen

Subject: [PATCH] debugfs - fix segfault on "stat" command with no open fs

This is a regression from commit
8fdf29117f922419bd5b3f741e5d554b1d5b8893, which attempts to access
current_fs via a feature check before we check that it's open.

Just moving the feature check below the open check should fix it.

Reported-by: Andrew Hecox <[email protected]>
Signed-off-by: Eric Sandeen <[email protected]>
---

Index: e2fsprogs/debugfs/debugfs.c
===================================================================
--- e2fsprogs.orig/debugfs/debugfs.c 2008-09-12 10:37:52.000000000 -0500
+++ e2fsprogs/debugfs/debugfs.c 2009-01-29 16:36:04.748574864 -0600
@@ -291,9 +291,6 @@ void do_show_super_stats(int argc, char
int c, header_only = 0;
int numdirs = 0, first, gdt_csum;

- gdt_csum = EXT2_HAS_RO_COMPAT_FEATURE(current_fs->super,
- EXT4_FEATURE_RO_COMPAT_GDT_CSUM);

2009-03-09 03:15:45

by Theodore Ts'o

Subject: Re: [PATCH] debugfs - fix segfault on "stat" command with no open fs

On Thu, Jan 29, 2009 at 05:46:28PM -0500, Eric Sandeen wrote:
> This is a regression from commit
> 8fdf29117f922419bd5b3f741e5d554b1d5b8893, which attempts to access
> current_fs via a feature check before we check that it's open.
>
> Just moving the feature check below the open check should fix it.

Thanks, applied to the e2fsprogs git tree.

- Ted