2009-08-06 02:43:27

by Eric Sandeen

[permalink] [raw]
Subject: [PATCH] filefrag: fix frag count in bmap case

The fragmentation count in the bmap case seems to be
off by one:

# echo foo > /mnt/test/bar
# filefrag /mnt/test/bar
/mnt/test/bar: 0 extents found

Signed-off-by: Eric Sandeen <[email protected]>
---

diff --git a/misc/filefrag.c b/misc/filefrag.c
index eed2b86..128a391 100644
--- a/misc/filefrag.c
+++ b/misc/filefrag.c
@@ -342,6 +342,8 @@ static void frag_report(const char *filename)
rc = get_bmap(fd, i, &block);
if (block == 0)
continue;
+ if (!num_extents)
+ num_extents++;
count++;
if (last_block && (block != last_block+1) ) {
if (verbose)




2009-08-16 03:50:22

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [PATCH] filefrag: fix frag count in bmap case

On Wed, Aug 05, 2009 at 09:43:23PM -0500, Eric Sandeen wrote:
> The fragmentation count in the bmap case seems to be
> off by one:
>
> # echo foo > /mnt/test/bar
> # filefrag /mnt/test/bar
> /mnt/test/bar: 0 extents found

Thanks, applied.

- Ted