2009-12-07 13:54:17

by root

Subject: [PATCH] fix ext2 parse_options printk

Hello,

I added KERN_* prexif in some log message. I choose KERN_NOTICE for message who looks something the user might be warned, because it isn't really a warning but it's something he should know.
I chose KERN_INFO for 2 elements which are what the user asked to be.

Tell me if there is any problem with my choices (or i make any mistake while sending you this patch) or anything else :)

Best regars,

2009-12-07 13:54:19

by root

Subject: [PATCH] fix ext2 parse_options printk

From: Jeremy Cochoy <[email protected]>

Signed-off-by: Jeremy Cochoy <[email protected]>
---
fs/ext2/super.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 1a9ffee..f28618f 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -505,7 +505,7 @@ static int parse_options (char * options,
#else
case Opt_user_xattr:
case Opt_nouser_xattr:
- printk("EXT2 (no)user_xattr options not supported\n");
+ printk(KERN_NOTICE "EXT2 (no)user_xattr options not supported\n");
break;
#endif
#ifdef CONFIG_EXT2_FS_POSIX_ACL
@@ -518,14 +518,14 @@ static int parse_options (char * options,
#else
case Opt_acl:
case Opt_noacl:
- printk("EXT2 (no)acl options not supported\n");
+ printk(KERN_NOTICE "EXT2 (no)acl options not supported\n");
break;
#endif
case Opt_xip:
#ifdef CONFIG_EXT2_FS_XIP
set_opt (sbi->s_mount_opt, XIP);
#else
- printk("EXT2 xip option not supported\n");
+ printk(KERN_NOTICE "EXT2 xip option not supported\n");
#endif
break;

@@ -550,11 +550,11 @@ static int parse_options (char * options,

case Opt_reservation:
set_opt(sbi->s_mount_opt, RESERVATION);
- printk("reservations ON\n");
+ printk(KERN_INFO "reservations ON\n");
break;
case Opt_noreservation:
clear_opt(sbi->s_mount_opt, RESERVATION);
- printk("reservations OFF\n");
+ printk(KERN_INFO "reservations OFF\n");
break;
case Opt_ignore:
break;
--
1.5.6.5

2009-12-08 10:00:32

by Jan Kara

Subject: Re: [PATCH] fix ext2 parse_options printk

On Mon 07-12-09 15:01:01, root wrote:
> From: Jeremy Cochoy <[email protected]>
>
> Signed-off-by: Jeremy Cochoy <[email protected]>
Thanks for the patch but it's actually already fixed in my tree due to
ext2 message unification patches. So should get into 2.6.33-rc1.

Honza
> ---
> fs/ext2/super.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 1a9ffee..f28618f 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -505,7 +505,7 @@ static int parse_options (char * options,
> #else
> case Opt_user_xattr:
> case Opt_nouser_xattr:
> - printk("EXT2 (no)user_xattr options not supported\n");
> + printk(KERN_NOTICE "EXT2 (no)user_xattr options not supported\n");
> break;
> #endif
> #ifdef CONFIG_EXT2_FS_POSIX_ACL
> @@ -518,14 +518,14 @@ static int parse_options (char * options,
> #else
> case Opt_acl:
> case Opt_noacl:
> - printk("EXT2 (no)acl options not supported\n");
> + printk(KERN_NOTICE "EXT2 (no)acl options not supported\n");
> break;
> #endif
> case Opt_xip:
> #ifdef CONFIG_EXT2_FS_XIP
> set_opt (sbi->s_mount_opt, XIP);
> #else
> - printk("EXT2 xip option not supported\n");
> + printk(KERN_NOTICE "EXT2 xip option not supported\n");
> #endif
> break;
>
> @@ -550,11 +550,11 @@ static int parse_options (char * options,
>
> case Opt_reservation:
> set_opt(sbi->s_mount_opt, RESERVATION);
> - printk("reservations ON\n");
> + printk(KERN_INFO "reservations ON\n");
> break;
> case Opt_noreservation:
> clear_opt(sbi->s_mount_opt, RESERVATION);
> - printk("reservations OFF\n");
> + printk(KERN_INFO "reservations OFF\n");
> break;
> case Opt_ignore:
> break;
> --
> 1.5.6.5
>