2013-12-23 02:30:40

by Eric Whitney

Subject: [PATCH] debugfs: silence build warning and remove incorrect error message

Commit fe56188b07 modified the code used to check the block number
argument to the command line -s switch, adding a call to com_err().
This causes a compile time warning because the third argument to
com_err() isn't a string. Also, when the block number argument is
bad it outputs an incorrect error message - "Operation not permitted".

Fix these minor problems by removing the call to com_err(). Other
code provides enough error reporting information in this case.

Signed-off-by: Eric Whitney <[email protected]>
---
debugfs/debugfs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
index 6982ff6..095741f 100644
--- a/debugfs/debugfs.c
+++ b/debugfs/debugfs.c
@@ -2458,10 +2458,8 @@ int main(int argc, char **argv)
break;
case 's':
retval = strtoblk(argv[0], optarg, &superblock);
- if (retval) {
- com_err(argv[0], retval, 0, debug_prog_name);
+ if (retval)
return 1;
- }
break;
case 'c':
catastrophic = 1;
--
1.8.3.2

2013-12-24 16:05:20

by Theodore Ts'o

Subject: Re: [PATCH] debugfs: silence build warning and remove incorrect error message

On Sun, Dec 22, 2013 at 09:30:35PM -0500, Eric Whitney wrote:
> Commit fe56188b07 modified the code used to check the block number
> argument to the command line -s switch, adding a call to com_err().
> This causes a compile time warning because the third argument to
> com_err() isn't a string. Also, when the block number argument is
> bad it outputs an incorrect error message - "Operation not permitted".
>
> Fix these minor problems by removing the call to com_err(). Other
> code provides enough error reporting information in this case.
>
> Signed-off-by: Eric Whitney <[email protected]>

Thanks, applied.

- Ted