2016-03-29 13:01:03

by Seth Forshee

Subject: [PATCH] ext4: Fix check of dqget() return value in ext4_ioctl_setproject()

A failed call to dqget() returns an ERR_PTR() and not null. Fix
the check in ext4_ioctl_setproject() to handle this correctly.

Fixes: 9b7365fc1c82 ("ext4: add FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR interface support")
Cc: [email protected] # v4.5
Signed-off-by: Seth Forshee <[email protected]>
---
fs/ext4/ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index 322f5bdbf76a..dd82cf1c4e39 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -365,7 +365,7 @@ static int ext4_ioctl_setproject(struct file *filp, __u32 projid)
struct dquot *transfer_to[MAXQUOTAS] = { };

transfer_to[PRJQUOTA] = dqget(sb, make_kqid_projid(kprojid));
- if (transfer_to[PRJQUOTA]) {
+ if (!IS_ERR(transfer_to[PRJQUOTA])) {
err = __dquot_transfer(inode, transfer_to);
dqput(transfer_to[PRJQUOTA]);
if (err)
--
1.9.1

2016-04-22 18:36:32

by Seth Forshee

Subject: Re: [PATCH] ext4: Fix check of dqget() return value in ext4_ioctl_setproject()

On Tue, Mar 29, 2016 at 08:01:03AM -0500, Seth Forshee wrote:
> A failed call to dqget() returns an ERR_PTR() and not null. Fix
> the check in ext4_ioctl_setproject() to handle this correctly.
>
> Fixes: 9b7365fc1c82 ("ext4: add FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR interface support")
> Cc: [email protected] # v4.5
> Signed-off-by: Seth Forshee <[email protected]>

Thought I'd check and see if this patch was forgotten, I sent it nearly
a month ago but the bug is still present.

Thanks,
Seth

2016-05-05 12:52:38

by Jan Kara

Subject: Re: [PATCH] ext4: Fix check of dqget() return value in ext4_ioctl_setproject()

On Fri 22-04-16 13:36:32, Seth Forshee wrote:
> On Tue, Mar 29, 2016 at 08:01:03AM -0500, Seth Forshee wrote:
> > A failed call to dqget() returns an ERR_PTR() and not null. Fix
> > the check in ext4_ioctl_setproject() to handle this correctly.
> >
> > Fixes: 9b7365fc1c82 ("ext4: add FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR interface support")
> > Cc: [email protected] # v4.5
> > Signed-off-by: Seth Forshee <[email protected]>
>
> Thought I'd check and see if this patch was forgotten, I sent it nearly
> a month ago but the bug is still present.

Yeah, it seems Ted forgot to pull the fix. Ted? BTW, feel free to add

Reviewed-by: Jan Kara <[email protected]>

Honza
--
Jan Kara <[email protected]>
SUSE Labs, CR

2016-05-05 14:53:17

by Theodore Ts'o

Subject: Re: [PATCH] ext4: Fix check of dqget() return value in ext4_ioctl_setproject()

On Thu, May 05, 2016 at 02:52:34PM +0200, Jan Kara wrote:
> On Fri 22-04-16 13:36:32, Seth Forshee wrote:
> > On Tue, Mar 29, 2016 at 08:01:03AM -0500, Seth Forshee wrote:
> > > A failed call to dqget() returns an ERR_PTR() and not null. Fix
> > > the check in ext4_ioctl_setproject() to handle this correctly.
> > >
> > > Fixes: 9b7365fc1c82 ("ext4: add FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR interface support")
> > > Cc: [email protected] # v4.5
> > > Signed-off-by: Seth Forshee <[email protected]>
> >
> > Thought I'd check and see if this patch was forgotten, I sent it nearly
> > a month ago but the bug is still present.
>
> Yeah, it seems Ted forgot to pull the fix. Ted? BTW, feel free to add
>
> Reviewed-by: Jan Kara <[email protected]>

Applied, thanks.

- Ted