2016-10-11 17:02:27

by Eric Biggers

Subject: [PATCH] ext4: correct endianness conversion in __xattr_check_inode()

It should be cpu_to_le32(), not le32_to_cpu(). No change in behavior.

Found with sparse, and this was the only endianness warning in fs/ext4/.

Signed-off-by: Eric Biggers <[email protected]>
---
fs/ext4/xattr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index c15d633..e90c5cd 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -241,7 +241,7 @@ __xattr_check_inode(struct inode *inode, struct ext4_xattr_ibody_header *header,
int error = -EFSCORRUPTED;

if (((void *) header >= end) ||
- (header->h_magic != le32_to_cpu(EXT4_XATTR_MAGIC)))
+ (header->h_magic != cpu_to_le32(EXT4_XATTR_MAGIC)))
goto errout;
error = ext4_xattr_check_names(entry, end, entry);
errout:
--
2.8.0.rc3.226.g39d4020

2016-10-12 10:36:55

by Jan Kara

Subject: Re: [PATCH] ext4: correct endianness conversion in __xattr_check_inode()

On Tue 11-10-16 10:01:26, Eric Biggers wrote:
> It should be cpu_to_le32(), not le32_to_cpu(). No change in behavior.
>
> Found with sparse, and this was the only endianness warning in fs/ext4/.
>
> Signed-off-by: Eric Biggers <[email protected]>

Looks good. You can add:

Reviewed-by: Jan Kara <[email protected]>

Honza

> ---
> fs/ext4/xattr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
> index c15d633..e90c5cd 100644
> --- a/fs/ext4/xattr.c
> +++ b/fs/ext4/xattr.c
> @@ -241,7 +241,7 @@ __xattr_check_inode(struct inode *inode, struct ext4_xattr_ibody_header *header,
> int error = -EFSCORRUPTED;
>
> if (((void *) header >= end) ||
> - (header->h_magic != le32_to_cpu(EXT4_XATTR_MAGIC)))
> + (header->h_magic != cpu_to_le32(EXT4_XATTR_MAGIC)))
> goto errout;
> error = ext4_xattr_check_names(entry, end, entry);
> errout:
> --
> 2.8.0.rc3.226.g39d4020
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Kara <[email protected]>
SUSE Labs, CR

2016-10-15 13:45:39

by Theodore Ts'o

Subject: Re: [PATCH] ext4: correct endianness conversion in __xattr_check_inode()

On Wed, Oct 12, 2016 at 12:36:46PM +0200, Jan Kara wrote:
> On Tue 11-10-16 10:01:26, Eric Biggers wrote:
> > It should be cpu_to_le32(), not le32_to_cpu(). No change in behavior.
> >
> > Found with sparse, and this was the only endianness warning in fs/ext4/.
> >
> > Signed-off-by: Eric Biggers <[email protected]>
>
> Looks good. You can add:
>
> Reviewed-by: Jan Kara <[email protected]>

Thanks, applied

- Ted