2020-04-14 13:59:09

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [PATCH] ext4: fix BUG_ON in fs/ext4/page_io.c:ext4_release_io_end()

On Mon, Apr 13, 2020 at 10:28:42PM -0400, Theodore Ts'o wrote:
> The function ext4_release_io_end() can be called by
> ext4_put_io_end_defer() with the EXT4_IO_UNWRITTEN flag set and
> io_end->size is 0. In that case, it's safe to release the io_end
> structure, since if io_end->size is zero, there is no unwritten region
> to release.
>
> This can be reproduced using generic/300, although not very reliably,
> and almost never using a freshly rebooted kernel.
>
> Google-Bug-Id: 15054006
> Signed-off-by: "Theodore Ts'o" <[email protected]>

NACK; this patch no longer applies given the move to use iomap for direct I/O.

- Ted