2007-08-16 22:39:44

by Eric Sandeen

Subject: [PATCH] provide missing mode for open-create in check_mntent_file

F8 is catching opens with O_CREAT flags and no mode now, and refusing
to build them...

Signed-off-by: Eric Sandeen <[email protected]>

Index: e2fsprogs-git/lib/ext2fs/ismounted.c
===================================================================
--- e2fsprogs-git.orig/lib/ext2fs/ismounted.c
+++ e2fsprogs-git/lib/ext2fs/ismounted.c
@@ -147,7 +147,7 @@ static errcode_t check_mntent_file(const
is_root:
#define TEST_FILE "/.ismount-test-file"
*mount_flags |= EXT2_MF_ISROOT;
- fd = open(TEST_FILE, O_RDWR|O_CREAT);
+ fd = open(TEST_FILE, O_RDWR|O_CREAT, 0644);
if (fd < 0) {
if (errno == EROFS)
*mount_flags |= EXT2_MF_READONLY;

2007-08-17 17:29:14

by Andreas Dilger

Subject: Re: [PATCH] provide missing mode for open-create in check_mntent_file

On Aug 16, 2007 17:37 -0500, Eric Sandeen wrote:
> F8 is catching opens with O_CREAT flags and no mode now, and refusing
> to build them...

Yay, we had bugs-o-plenty in Lustre because of this being done in apps.

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

2007-10-19 20:15:39

by Eric Sandeen

Subject: Re: [PATCH] provide missing mode for open-create in check_mntent_file

Eric Sandeen wrote:
> F8 is catching opens with O_CREAT flags and no mode now, and refusing
> to build them...

Ping? I don't see this in git yet.

Thanks,
-Eric

> Signed-off-by: Eric Sandeen <[email protected]>
>
> Index: e2fsprogs-git/lib/ext2fs/ismounted.c
> ===================================================================
> --- e2fsprogs-git.orig/lib/ext2fs/ismounted.c
> +++ e2fsprogs-git/lib/ext2fs/ismounted.c
> @@ -147,7 +147,7 @@ static errcode_t check_mntent_file(const
> is_root:
> #define TEST_FILE "/.ismount-test-file"
> *mount_flags |= EXT2_MF_ISROOT;
> - fd = open(TEST_FILE, O_RDWR|O_CREAT);
> + fd = open(TEST_FILE, O_RDWR|O_CREAT, 0644);
> if (fd < 0) {
> if (errno == EROFS)
> *mount_flags |= EXT2_MF_READONLY;
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html