2009-02-23 17:26:16

by Jim Meyering

Subject: [PATCH] * request_tbl.c (ss_add_request_table): Avoid leak upon failed realloc.

Signed-off-by: Jim Meyering <[email protected]>
---
Here's another found via inspection.
It looks like it can only affect debugfs.

lib/ss/request_tbl.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/lib/ss/request_tbl.c b/lib/ss/request_tbl.c
index 4027af8..4632d65 100644
--- a/lib/ss/request_tbl.c
+++ b/lib/ss/request_tbl.c
@@ -27,18 +27,19 @@ void ss_add_request_table(sci_idx, rqtbl_ptr, position, code_ptr)
{
register ss_data *info;
register int i, size;
+ ssrt **t;

info = ss_info(sci_idx);
for (size=0; info->rqt_tables[size] != (ssrt *)NULL; size++)
;
/* size == C subscript of NULL == #elements */
size += 2; /* new element, and NULL */
- info->rqt_tables = (ssrt **)realloc(info->rqt_tables,
- (unsigned)size*sizeof(ssrt));
- if (info->rqt_tables == (ssrt **)NULL) {
+ t = (ssrt **)realloc(info->rqt_tables, (unsigned)size*sizeof(ssrt));
+ if (t == (ssrt **)NULL) {
*code_ptr = errno;
return;
}
+ info->rqt_tables = t;
if (position > size - 2)
position = size - 2;

--
1.6.2.rc1.266.g4bdf

2009-03-09 03:15:43

by Theodore Ts'o

Subject: Re: [PATCH] * request_tbl.c (ss_add_request_table): Avoid leak upon failed realloc.

Thanks, applied.

- Ted