2021-04-14 07:01:15

by Eric Biggers

[permalink] [raw]
Subject: [xfstests-bld PATCH] test-appliance: un-exclude encrypt+casefold test

From: Eric Biggers <[email protected]>

This is needed to test the encryption and casefolding features in
combination.

Signed-off-by: Eric Biggers <[email protected]>
---
.../test-appliance/files/root/fs/ext4/cfg/encrypt.exclude | 3 ---
1 file changed, 3 deletions(-)

diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
index b7f6ea3..20abf5e 100644
--- a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
+++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
@@ -30,9 +30,6 @@ generic/587
generic/600
generic/601

-# encryption doesn't play well with casefold (at least not yet)
-generic/556
-
# generic/204 tests ENOSPC handling; it doesn't correctly
# anticipate the external extended attribute required when
# using a 1k block size
--
2.31.1


2021-04-14 07:22:20

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [xfstests-bld PATCH] test-appliance: un-exclude encrypt+casefold test

On Tue, Apr 13, 2021 at 02:53:00PM -0700, Eric Biggers wrote:
> From: Eric Biggers <[email protected]>
>
> This is needed to test the encryption and casefolding features in
> combination.

Yeah, this is has been on my radar screen, but it's been on my todo
list to submit a patch to generic/556 something like:

if [ "$FSTYP" = "ext4" -a ! -f /sys/fs/ext4/features/encrypted_casefold ]; then
_notrun "ext4 file system does not support encrypted casefold"
fi

before removing generic/556 from the encrypt.exclude list.

I'll probably get to it by this weekend, unless someone beats me to
it.

Cheers,

- Ted