2021-06-09 13:42:29

by yangerkun

Subject: [PATCH] ext4: no need to verify new add extent block

ext4_ext_grow_indepth will add a new extent block which has init the
expected content. We can mark this buffer as verified so to stop a
useless check in __read_extent_tree_block.

Signed-off-by: yangerkun <[email protected]>
---
fs/ext4/extents.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index cbf37b2cf871..6ca5be8a8fc2 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1306,6 +1306,7 @@ static int ext4_ext_grow_indepth(handle_t *handle, struct inode *inode,
neh->eh_magic = EXT4_EXT_MAGIC;
ext4_extent_block_csum_set(inode, neh);
set_buffer_uptodate(bh);
+ set_buffer_verified(bh);
unlock_buffer(bh);

err = ext4_handle_dirty_metadata(handle, inode, bh);
--
2.31.1

2021-06-09 14:21:08

by Jan Kara

Subject: Re: [PATCH] ext4: no need to verify new add extent block

On Wed 09-06-21 15:55:45, yangerkun wrote:
> ext4_ext_grow_indepth will add a new extent block which has init the
> expected content. We can mark this buffer as verified so to stop a
> useless check in __read_extent_tree_block.
>
> Signed-off-by: yangerkun <[email protected]>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

Honza

> ---
> fs/ext4/extents.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index cbf37b2cf871..6ca5be8a8fc2 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -1306,6 +1306,7 @@ static int ext4_ext_grow_indepth(handle_t *handle, struct inode *inode,
> neh->eh_magic = EXT4_EXT_MAGIC;
> ext4_extent_block_csum_set(inode, neh);
> set_buffer_uptodate(bh);
> + set_buffer_verified(bh);
> unlock_buffer(bh);
>
> err = ext4_handle_dirty_metadata(handle, inode, bh);
> --
> 2.31.1
>
--
Jan Kara <[email protected]>
SUSE Labs, CR

2021-06-24 14:30:13

by Theodore Ts'o

Subject: Re: [PATCH] ext4: no need to verify new add extent block

On Wed, Jun 09, 2021 at 03:55:45PM +0800, yangerkun wrote:
> ext4_ext_grow_indepth will add a new extent block which has init the
> expected content. We can mark this buffer as verified so to stop a
> useless check in __read_extent_tree_block.
>
> Signed-off-by: yangerkun <[email protected]>

Applied, thanks.

- Ted