2021-06-30 08:28:09

by wuguanghao

Subject: [PATCH v2 08/12] misc: fix potential segmentation fault problem in scandir()

From: Zhiqiang Liu <[email protected]>

In scandir(), temp_list[num_dent] is allocated by calling
malloc(), we should check whether malloc() returns NULL before
accessing temp_list[num_dent].

Signed-off-by: Zhiqiang Liu <[email protected]>
Signed-off-by: Wu Guanghao <[email protected]>
---
misc/create_inode.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/misc/create_inode.c b/misc/create_inode.c
index d62e1cb4..869b0614 100644
--- a/misc/create_inode.c
+++ b/misc/create_inode.c
@@ -771,6 +771,9 @@ static int scandir(const char *dir_name, struct dirent ***name_list,
}
// add the copy of dirent to the list
temp_list[num_dent] = (struct dirent*)malloc((dent->d_reclen + 3) & ~3);
+ if (!temp_list[num_dent]) {
+ goto out;
+ }
memcpy(temp_list[num_dent], dent, dent->d_reclen);
num_dent++;
}
--
2.19.1

2021-07-16 03:45:09

by Theodore Ts'o

Subject: Re: [PATCH v2 08/12] misc: fix potential segmentation fault problem in scandir()

On Wed, Jun 30, 2021 at 04:27:20PM +0800, wuguanghao wrote:
> From: Zhiqiang Liu <[email protected]>
>
> In scandir(), temp_list[num_dent] is allocated by calling
> malloc(), we should check whether malloc() returns NULL before
> accessing temp_list[num_dent].
>
> Signed-off-by: Zhiqiang Liu <[email protected]>
> Signed-off-by: Wu Guanghao <[email protected]>

Thanks, applied.

- Ted