2022-08-15 13:04:14

by JunChao Sun

Subject: [PATCH] Documentation: ext4: correct the document about superblock

The description of s_lastcheck_hi, s_first_error_time_hi, and
s_last_error_time_hi fields refer to themselves, while these means
referring to upper 8 bits (byte) of corresponding fields (s_lastcheck,
s_first_error_time, and s_last_error_time). Correct the mistake.

Signed-off-by: JunChao Sun <[email protected]>
---
Documentation/filesystems/ext4/super.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/filesystems/ext4/super.rst b/Documentation/filesystems/ext4/super.rst
index 268888522e35..0152888cac29 100644
--- a/Documentation/filesystems/ext4/super.rst
+++ b/Documentation/filesystems/ext4/super.rst
@@ -456,15 +456,15 @@ The ext4 superblock is laid out as follows in
* - 0x277
- __u8
- s_lastcheck_hi
- - Upper 8 bits of the s_lastcheck_hi field.
+ - Upper 8 bits of the s_lastcheck field.
* - 0x278
- __u8
- s_first_error_time_hi
- - Upper 8 bits of the s_first_error_time_hi field.
+ - Upper 8 bits of the s_first_error_time field.
* - 0x279
- __u8
- s_last_error_time_hi
- - Upper 8 bits of the s_last_error_time_hi field.
+ - Upper 8 bits of the s_last_error_time field.
* - 0x27A
- __u8
- s_pad[2]
--
2.17.1

2022-08-15 14:26:15

by Darrick J. Wong

Subject: Re: [PATCH] Documentation: ext4: correct the document about superblock

On Mon, Aug 15, 2022 at 05:52:33AM -0700, JunChao Sun wrote:
> The description of s_lastcheck_hi, s_first_error_time_hi, and
> s_last_error_time_hi fields refer to themselves, while these means
> referring to upper 8 bits (byte) of corresponding fields (s_lastcheck,
> s_first_error_time, and s_last_error_time). Correct the mistake.
>
> Signed-off-by: JunChao Sun <[email protected]>

Looks ok,
Reviewed-by: Darrick J. Wong <[email protected]>

--D

> ---
> Documentation/filesystems/ext4/super.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/filesystems/ext4/super.rst b/Documentation/filesystems/ext4/super.rst
> index 268888522e35..0152888cac29 100644
> --- a/Documentation/filesystems/ext4/super.rst
> +++ b/Documentation/filesystems/ext4/super.rst
> @@ -456,15 +456,15 @@ The ext4 superblock is laid out as follows in
> * - 0x277
> - __u8
> - s_lastcheck_hi
> - - Upper 8 bits of the s_lastcheck_hi field.
> + - Upper 8 bits of the s_lastcheck field.
> * - 0x278
> - __u8
> - s_first_error_time_hi
> - - Upper 8 bits of the s_first_error_time_hi field.
> + - Upper 8 bits of the s_first_error_time field.
> * - 0x279
> - __u8
> - s_last_error_time_hi
> - - Upper 8 bits of the s_last_error_time_hi field.
> + - Upper 8 bits of the s_last_error_time field.
> * - 0x27A
> - __u8
> - s_pad[2]
> --
> 2.17.1
>

2022-08-29 16:33:52

by Jonathan Corbet

Subject: Re: [PATCH] Documentation: ext4: correct the document about superblock

JunChao Sun <[email protected]> writes:

> The description of s_lastcheck_hi, s_first_error_time_hi, and
> s_last_error_time_hi fields refer to themselves, while these means
> referring to upper 8 bits (byte) of corresponding fields (s_lastcheck,
> s_first_error_time, and s_last_error_time). Correct the mistake.
>
> Signed-off-by: JunChao Sun <[email protected]>
> ---
> Documentation/filesystems/ext4/super.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/filesystems/ext4/super.rst b/Documentation/filesystems/ext4/super.rst
> index 268888522e35..0152888cac29 100644
> --- a/Documentation/filesystems/ext4/super.rst
> +++ b/Documentation/filesystems/ext4/super.rst
> @@ -456,15 +456,15 @@ The ext4 superblock is laid out as follows in
> * - 0x277
> - __u8
> - s_lastcheck_hi
> - - Upper 8 bits of the s_lastcheck_hi field.
> + - Upper 8 bits of the s_lastcheck field.
> * - 0x278
> - __u8
> - s_first_error_time_hi
> - - Upper 8 bits of the s_first_error_time_hi field.
> + - Upper 8 bits of the s_first_error_time field.
> * - 0x279
> - __u8
> - s_last_error_time_hi
> - - Upper 8 bits of the s_last_error_time_hi field.
> + - Upper 8 bits of the s_last_error_time field.
> * - 0x27A
> - __u8

Applied to the docs tree, thanks.

jon