[resent since the first mail doesn't seem to make it to this list]
Hi,
using atoi() should be avoided in the option parser since it doesn't check
for errors. I almost destroyed an important filesystem since I
specified "e2fsck -C -n" and -n was parsed as option to -C
Cheers,
Bernd
On Wed, Aug 01, 2007 at 04:50:04PM +0200, Bernd Schubert wrote:
> [resent since the first mail doesn't seem to make it to this list]
>
> using atoi() should be avoided in the option parser since it doesn't check
> for errors. I almost destroyed an important filesystem since I
> specified "e2fsck -C -n" and -n was parsed as option to -C
Hi Bernd,
Can you please include a DCO. i.e.,
Signed-off-by: Bernd Schubert <[email protected]>
In your patch submissions. See the SUBMITTING-PATCHES file in the
top-level directory of e2fsprogs source tree for the significance of
the Signed-off-by line. For this patch, can you indicate whether you
are willing to add a Signed-off-by: DCO?
Thanks, regards,
- Ted
Hello Ted,
> In your patch submissions. See the SUBMITTING-PATCHES file in the
> top-level directory of e2fsprogs source tree for the significance of
> the Signed-off-by line. For this patch, can you indicate whether you
> are willing to add a Signed-off-by: DCO?
sorry that I did not read that file and so didn't know a signed-off is
required.
Sure I'm willing to add a signed-off :) I'm also adding the patch again to
this mail.
Signed-off-by: Bernd Schubert <[email protected]>
Cheers,
Bernd
--
Bernd Schubert
Q-Leap Networks GmbH