From: Badari Pulavarty Subject: Re: BUG: warning at fs/ext3/inode.c:1016/ext3_getblk() Date: Tue, 05 Sep 2006 15:43:48 -0700 Message-ID: <1157496228.23501.21.camel@dyn9047017100.beaverton.ibm.com> References: <20060905171049.GB27433@ele.uri.edu> <44FDE6E5.3090009@us.ibm.com> <20060905214703.GA16449@ele.uri.edu> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: lkml , ext4 Return-path: Received: from e33.co.us.ibm.com ([32.97.110.151]:15546 "EHLO e33.co.us.ibm.com") by vger.kernel.org with ESMTP id S965250AbWIEWk2 (ORCPT ); Tue, 5 Sep 2006 18:40:28 -0400 To: Will Simoneau , akpm@osdl.org, cmm@us.ibm.com In-Reply-To: <20060905214703.GA16449@ele.uri.edu> Sender: linux-ext4-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Tue, 2006-09-05 at 17:47 -0400, Will Simoneau wrote: > On 14:06 Tue 05 Sep , Badari Pulavarty wrote: > > Will Simoneau wrote: > > >Has anyone seen this before? These three traces occured at different times > > >today when three new user accounts (and associated quotas) were created. > > >This > > >machine is an NFS server which uses quotas on an ext3 fs (dir_index is on). > > >Kernel is 2.6.17.11 on an x86 smp w/64G highmem; 4G ram is installed. The > > >affected filesystem is on a software raid1 of two hardware raid0 volumes > > >from a > > >megaraid card. > > > > > >BUG: warning at fs/ext3/inode.c:1016/ext3_getblk() > > > ext3_getblk+0x98/0x2a6 md_wakeup_thread+0x26/0x2a > > > ext3_bread+0x1f/0x88 ext3_quota_read+0x136/0x1ae > > > v1_read_dqblk+0x61/0xac dquot_acquire+0xf6/0x107 > > > ext3_acquire_dquot+0x46/0x68 dqget+0x155/0x1e7 > > > dquot_transfer+0x3e0/0x3e9 dput+0x23/0x13e I think, we found your problem. ext3_getblk() is not handling HOLE correctly. Does this patch help ? Mingming, what do you think ? Thanks, Badari ext3_get_blocks_handle() returns number of blocks it mapped. It returns 0 in case of HOLE. ext3_getblk() should handle HOLE properly (currently its dumping warning stack and returning -EIO). Signed-off-by: Badari Pulavarty --- fs/ext3/inode.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) Index: linux-2.6.18-rc5/fs/ext3/inode.c =================================================================== --- linux-2.6.18-rc5.orig/fs/ext3/inode.c 2006-08-27 20:41:48.000000000 -0700 +++ linux-2.6.18-rc5/fs/ext3/inode.c 2006-09-05 15:32:57.000000000 -0700 @@ -1009,11 +1009,12 @@ struct buffer_head *ext3_getblk(handle_t buffer_trace_init(&dummy.b_history); err = ext3_get_blocks_handle(handle, inode, block, 1, &dummy, create, 1); - if (err == 1) { + /* + * ext3_get_blocks_handle() returns number of blocks + * mapped. 0 in case of a HOLE. + */ + if (err > 0) { err = 0; - } else if (err >= 0) { - WARN_ON(1); - err = -EIO; } *errp = err; if (!err && buffer_mapped(&dummy)) {