From: Dave Kleikamp Subject: Re: [PATCH] ext3_getblk should handle HOLE correctly Date: Wed, 06 Sep 2006 12:42:55 -0500 Message-ID: <1157564575.8200.16.camel@kleikamp.austin.ibm.com> References: <1157564346.23501.49.camel@dyn9047017100.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: akpm@osdl.org, lkml , ext4 , Will Simoneau , cmm@us.ibm.com Return-path: Received: from e5.ny.us.ibm.com ([32.97.182.145]:30936 "EHLO e5.ny.us.ibm.com") by vger.kernel.org with ESMTP id S1751214AbWIFRnB (ORCPT ); Wed, 6 Sep 2006 13:43:01 -0400 To: Badari Pulavarty In-Reply-To: <1157564346.23501.49.camel@dyn9047017100.beaverton.ibm.com> Sender: linux-ext4-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Wed, 2006-09-06 at 10:39 -0700, Badari Pulavarty wrote: > Index: linux-2.6.18-rc5/fs/ext3/inode.c > =================================================================== > --- linux-2.6.18-rc5.orig/fs/ext3/inode.c 2006-08-27 20:41:48.000000000 -0700 > +++ linux-2.6.18-rc5/fs/ext3/inode.c 2006-09-05 15:32:57.000000000 -0700 > @@ -1009,11 +1009,12 @@ struct buffer_head *ext3_getblk(handle_t > buffer_trace_init(&dummy.b_history); > err = ext3_get_blocks_handle(handle, inode, block, 1, > &dummy, create, 1); > - if (err == 1) { > + /* > + * ext3_get_blocks_handle() returns number of blocks > + * mapped. 0 in case of a HOLE. > + */ > + if (err > 0) { > err = 0; > - } else if (err >= 0) { > - WARN_ON(1); > - err = -EIO; > } I'd get rid of the {} too. > *errp = err; > if (!err && buffer_mapped(&dummy)) { -- David Kleikamp IBM Linux Technology Center