From: Andreas Dilger Subject: Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race Date: Thu, 18 Jan 2007 03:43:38 -0700 Message-ID: <20070118104338.GZ5236@schatzie.adilger.int> References: <45A7F384.3050303@redhat.com> <20070117224304.GM5236@schatzie.adilger.int> <45AEA789.20407@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: ext4 development Return-path: Received: from mail.clusterfs.com ([206.168.112.78]:44040 "EHLO mail.clusterfs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751999AbXARLRO (ORCPT ); Thu, 18 Jan 2007 06:17:14 -0500 To: Eric Sandeen Content-Disposition: inline In-Reply-To: <45AEA789.20407@redhat.com> Sender: linux-ext4-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Jan 17, 2007 16:47 -0600, Eric Sandeen wrote: > Andreas Dilger wrote: > > On Jan 12, 2007 14:45 -0600, Eric Sandeen wrote: > >> p.s. ext3_inc_count and ext3_dec_count seem misnamed, have an unused > >> arg, and are very infrequently called. I'll probably submit a patch > >> to just put the single line of code into the caller, too. > > > > I use those functions in the > 32000 subdirs patch to handle the case > > where a directory overflows the i_nlinks counter and needs to be set > > to have i_nlinks = 1. > > > > Patch was posted previously, but rejected because there is a potential > > for directory loss if the filesystem is mounted on an older kernel > > (i_nlinks == 1, subdir is removed, directory is truncated). I need to > > add an ROCOMPAT feature in order to handle this, but haven't gotten > > around to doing it. > > Ah, ok. Sorry I'd missed that. Can we at least rename them to > something that makes sense? :) I have no objection to renaming them, but had previously left them as-is because it meant a smaller patch. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc.