From: Anton Altaparmakov Subject: Re: [RFC] Heads up on sys_fallocate() Date: Mon, 5 Mar 2007 15:07:26 +0000 Message-ID: <13E89496-3752-42ED-AE23-F1EF6DE23029@cam.ac.uk> References: <20070117094658.GA17390@amitarora.in.ibm.com> <1172789056.11165.42.camel@kleikamp.austin.ibm.com> <20070301233819.GB31072@infradead.org> <200703032345.33137.arnd@arndb.de> <0DA8B217-DDD4-4E05-B000-DEBE3BE55B94@cam.ac.uk> <45EB4A55.3060908@redhat.com> <8A8B28AA-3481-4CFF-AEAA-0CB4CCDFF9F9@cam.ac.uk> <20070305143703.GF26781@thunk.org> Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Content-Transfer-Encoding: 7bit Cc: Ulrich Drepper , Arnd Bergmann , Christoph Hellwig , Dave Kleikamp , Andrew Morton , "Amit K. Arora" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, suparna@in.ibm.com, cmm@us.ibm.com, alex@clusterfs.com, suzuki@in.ibm.com To: Theodore Tso Return-path: Received: from ppsw-0.csi.cam.ac.uk ([131.111.8.130]:49819 "EHLO ppsw-0.csi.cam.ac.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933505AbXCEPIz (ORCPT ); Mon, 5 Mar 2007 10:08:55 -0500 In-Reply-To: <20070305143703.GF26781@thunk.org> Sender: linux-ext4-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On 5 Mar 2007, at 14:37, Theodore Tso wrote: > On Sun, Mar 04, 2007 at 11:22:06PM +0000, Anton Altaparmakov wrote: >> And I specifically did NOT update the initialized size in the inode >> thus it will remain at its old value thus all new allocated blocks >> will be considered as present but not initialized thus a read will >> always return zero whilst a write will do the right thing and pad >> with zeroes as necessary (if the write is smaller than the block >> size, etc). > > You're describing a method of doing in-advance preallocation > where the filesystem format explicitly has support for this kind of > feature in a way that doesn't require pre-zeroing the data blocks in > question. Indeed. > The question which this subthread was concerned about was > whether the kernel should get involved in initializing datablocks in > the case where the filesystem format does not have this support, or > whether this functionality should continue to be done in userspace. > Given that glibc already has to support this for older kernels, I > would argue that there's no point putting in generic support for > filesystem that can't support a more advanced way of doing things. Yes, I understood that after I had sent my post... And yes, I would agree. If glibc already does this there does not appear to be any value in just moving existing functionality into the kernel. Simply let "dumb" file systems return ENOSYS and let glibc do it... And any FS which can do it better can implement the function and then glibc should not go anywhere near it. Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer, http://www.linux-ntfs.org/