From: Theodore Tso Subject: Re: [PATCH] e2fsprogs: Offsets of EAs in inode need not be sorted Date: Fri, 20 Apr 2007 08:38:32 -0400 Message-ID: <20070420123832.GB18529@thunk.org> References: <1176984336.3812.10.camel@garfield> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-ext4 To: Kalpak Shah Return-path: Received: from THUNK.ORG ([69.25.196.29]:44834 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992663AbXDTMif (ORCPT ); Fri, 20 Apr 2007 08:38:35 -0400 Content-Disposition: inline In-Reply-To: <1176984336.3812.10.camel@garfield> Sender: linux-ext4-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Thu, Apr 19, 2007 at 05:35:36PM +0530, Kalpak Shah wrote: > Hi, > > This patch removes a code snippet from check_ea_in_inode() in pass1 > which checks if the EA values in the inode are sorted or not. The > comments in fs/ext*/xattr.c state that the EA values in the external > EA block are sorted but those in the inode need not be sorted. I > have also attached a test image which has unsorted EAs in the > inodes. The current e2fsck wrongly clears the EAs in the inode. Hmm, have you been able to create test images that have unsorted EA's in inodes using a standard ext3 kernel implementat? If so, then this is a patch which we should push to the distro's since it could cause data loss, and cause serious malfunctions, especially for people who have SELinux enabled and are using large inodes for the EA-in-inode feature.... - Ted