From: Mingming Cao Subject: Re: Fix section conflict of ext4_ext_{find_goal,invalidate_cache} Date: Tue, 15 May 2007 11:59:08 -0700 Message-ID: <1179255549.4819.7.camel@dyn9047017103.beaverton.ibm.com> References: <20070515171527.GA20407@deprecation.cyrius.com> <1179252599.2836.127.camel@dyn9047017100.beaverton.ibm.com> Reply-To: cmm@us.ibm.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Martin Michlmayr , ext4 To: Badari Pulavarty , Alex Tomas Return-path: Received: from e33.co.us.ibm.com ([32.97.110.151]:60456 "EHLO e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754940AbXEOS72 (ORCPT ); Tue, 15 May 2007 14:59:28 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e33.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id l4FIxP9N026356 for ; Tue, 15 May 2007 14:59:25 -0400 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l4FIxPFf252328 for ; Tue, 15 May 2007 12:59:25 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l4FIxOJ1030280 for ; Tue, 15 May 2007 12:59:25 -0600 In-Reply-To: <1179252599.2836.127.camel@dyn9047017100.beaverton.ibm.com> Sender: linux-ext4-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Tue, 2007-05-15 at 11:09 -0700, Badari Pulavarty wrote: > On Tue, 2007-05-15 at 19:15 +0200, Martin Michlmayr wrote: > > Building with GCC 4.2, I get the following error: > > > > CC [M] fs/ext4/extents.o > > fs/ext4/extents.c:2166: error: __ksymtab_ext4_ext_find_goal causes a section type conflict > > fs/ext4/extents.c:2163: error: __ksymtab_ext4_ext_invalidate_cache causes a section type conflict > > > > This is because ext4_ext_find_goal and ext4_ext_invalidate_cache are > > declared static but also exported. > > Hmm.. Why are these exported ? > Looking at the code > > > EXPORT_SYMBOL(ext4_ext_invalidate_cache); > EXPORT_SYMBOL(ext4_ext_insert_extent); > EXPORT_SYMBOL(ext4_ext_walk_space); > EXPORT_SYMBOL(ext4_ext_find_goal); > EXPORT_SYMBOL(ext4_ext_calc_credits_for_insert); > there is one more EXPORT_SYMBOL(ext4_mark_inode_dirty); And with fallocate() patch, EXPORT_SYMBOL(ext4_fallocate); > Mingming ? Why are we exporting these ? > Don't know. They should all used by ext4 only. Alex, can we remove these exported symbols? Mingming