From: "Jose R. Santos" <jrs@us.ibm.com>
Subject: Re: [PATCH] JBD2: Change debug file path
Date: Fri, 8 Jun 2007 07:01:47 -0500
Message-ID: <20070608070147.7e021685@gara>
References: <20070607234537.56537f85@gara>
	<20070608070812.GE5181@schatzie.adilger.int>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: linux-ext4@vger.kernel.org
To: Andreas Dilger <adilger@clusterfs.com>
In-Reply-To: <20070608070812.GE5181@schatzie.adilger.int>
Sender: linux-ext4-owner@vger.kernel.org

On Fri, 8 Jun 2007 01:08:12 -0600
Andreas Dilger <adilger@clusterfs.com> wrote:

> On Jun 07, 2007  23:45 -0500, Jose R. Santos wrote:
> > The jbd2-debug file used to be located in /proc/sys/fs/jbd2-debug, but
> > create_proc_entry() does not do lookups on file names with more that one
> > directory deep.  This causes the entry creation to fail and hence, no proc
> > file is created.  This patch moves the file to /proc/jbd2-degug.
> > 
> > The file could be move to /proc/fs/jbd2/jbd2-debug, but it would require
> > some minor alterations to the jbd-stats patch.
> 
> I don't think we really want to be adding top-level files in /proc.
> What about using the "debugfs" filesystem (not to be confused with
> the e2fsprogs 'debugfs' command)?

I agree.  Was feeling kind of lazy though and didn't want to to much
time on this issue. :)

I'll look into changing jbd and jbd2 into using debugfs.

-JRS