From: Mingming Cao Subject: [EXT4 set 9][PATCH 2/5]Morecleanups: use is_power_of_2 () in fill_super Date: Sun, 01 Jul 2007 03:38:37 -0400 Message-ID: <1183275518.4010.138.camel@localhost.localdomain> Reply-To: cmm@us.ibm.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org Return-path: Received: from e34.co.us.ibm.com ([32.97.110.152]:59604 "EHLO e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757352AbXGAHij (ORCPT ); Sun, 1 Jul 2007 03:38:39 -0400 Sender: linux-ext4-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org Subject: is_power_of_2: ext4/super.c From: vignesh babu Replace (n & (n-1)) in the context of power of 2 checks with is_power_of_2() Signed-off-by: vignesh babu Cc: Signed-off-by: Andrew Morton Signed-off-by: Dave Kleikamp --- fs/ext4/super.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletion(-) diff -puN fs/ext4/super.c~is_power_of_2-ext4-superc fs/ext4/super.c --- a/fs/ext4/super.c~is_power_of_2-ext4-superc +++ a/fs/ext4/super.c @@ -36,6 +36,7 @@ #include #include #include +#include #include @@ -1662,7 +1663,7 @@ static int ext4_fill_super (struct super sbi->s_inode_size = le16_to_cpu(es->s_inode_size); sbi->s_first_ino = le32_to_cpu(es->s_first_ino); if ((sbi->s_inode_size < EXT4_GOOD_OLD_INODE_SIZE) || - (sbi->s_inode_size & (sbi->s_inode_size - 1)) || + (!is_power_of_2(sbi->s_inode_size)) || (sbi->s_inode_size > blocksize)) { printk (KERN_ERR "EXT4-fs: unsupported inode size: %d\n", _ Patches currently in -mm which might be from vignesh.babu@wipro.com are git-ubi.patch use-is_power_of_2-in-cxgb3-cxgb3_mainc.patch use-is_power_of_2-in-myri10ge-myri10gec.patch is_power_of_2-ext3-superc.patch is_power_of_2-ext4-superc.patch is_pwoer_of_2-jbd.patch