From: Andrew Morton Subject: Re: [EXT4 set 1][PATCH 2/2] Enable extents by default for ext4dev Date: Tue, 10 Jul 2007 16:30:15 -0700 Message-ID: <20070710163015.ab40ed2a.akpm@linux-foundation.org> References: <1183275361.4010.119.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Theodore Tso , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org To: cmm@us.ibm.com Return-path: Received: from smtp2.linux-foundation.org ([207.189.120.14]:38290 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759736AbXGJXa2 (ORCPT ); Tue, 10 Jul 2007 19:30:28 -0400 In-Reply-To: <1183275361.4010.119.camel@localhost.localdomain> Sender: linux-ext4-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Sun, 01 Jul 2007 03:36:01 -0400 Mingming Cao wrote: > Turn on extents feature by default in ext4 filesystem. User could use > -o noextents to turn it off. > Oh, there you go. > > Index: linux-2.6.22-rc4/fs/ext4/super.c > =================================================================== > --- linux-2.6.22-rc4.orig/fs/ext4/super.c 2007-06-11 17:02:22.000000000 -0700 > +++ linux-2.6.22-rc4/fs/ext4/super.c 2007-06-11 17:03:09.000000000 -0700 > @@ -1546,6 +1546,12 @@ > > set_opt(sbi->s_mount_opt, RESERVATION); > > + /* > + * turn on extents feature by default in ext4 filesystem > + * User -o noextents to turn it off > + */ > + set_opt (sbi->s_mount_opt, EXTENTS); > + Broken coding style. Please feed all the ext4 patches through scripts/checkpatch.pl (preferably version 0.07 - see Andy's patch on lkml) and then consider addressing the (quite large) number of mistakes which are detected.