From: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs
Date: Tue, 10 Jul 2007 21:42:21 -0700
Message-ID: <20070710214221.26539eb6.akpm@linux-foundation.org>
References: <1183275490.4010.134.camel@localhost.localdomain>
	<20070710193117.a4ef6298.akpm@linux-foundation.org>
	<f56c1ba00707102021k13a758cbx66cbb6ec8bffac49@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: cmm@us.ibm.com, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org
To: =?ISO-8859-1?B?IkPpZHJpYyBBdWdvbm5ldCI=?=
	<cedric.augonnet@gmail.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
In-Reply-To: <f56c1ba00707102021k13a758cbx66cbb6ec8bffac49@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-ext4.vger.kernel.org

On Tue, 10 Jul 2007 23:21:49 -0400 "C=E9dric Augonnet" <cedric.augonnet=
@gmail.com> wrote:

> 2007/7/10, Andrew Morton <akpm@linux-foundation.org>:
>=20
> Hi all,
>=20
> > > +     size =3D sizeof(struct transaction_stats_s);
> > > +     s->stats =3D kmalloc(size, GFP_KERNEL);
> > > +     if (s =3D=3D NULL) {
> > > +             kfree(s);
> > > +             return -EIO;
> >
> > ENOMEM
>=20
> I'm sorry if i missed some point, but i just don't see the use of suc=
h
> a kfree here, not sure Andrew meant you should only return ENOMEM
> instead, but why issuing those kfree(NULL), instead of just a if (!s)
> return ENOMEM ?
>=20

You found a bug.  It was meant to be

	if (s->stats =3D=3D NULL)


-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel=
" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html