From: Christoph Hellwig Subject: Re: [EXT4 set 4][PATCH 4/5] i_version:ext4 inode version update Date: Wed, 11 Jul 2007 13:02:47 +0100 Message-ID: <20070711120247.GA26370@infradead.org> References: <1183275465.4010.130.camel@localhost.localdomain> <20070711084737.GA17675@infradead.org> <20070711115224.GT6417@schatzie.adilger.int> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: Christoph Hellwig , Mingming Cao , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, nfsv4@linux-nfs.org Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:45956 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756698AbXGKMCt (ORCPT ); Wed, 11 Jul 2007 08:02:49 -0400 Content-Disposition: inline In-Reply-To: <20070711115224.GT6417@schatzie.adilger.int> Sender: linux-ext4-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Wed, Jul 11, 2007 at 05:52:24AM -0600, Andreas Dilger wrote: > On Jul 11, 2007 09:47 +0100, Christoph Hellwig wrote: > > On Sun, Jul 01, 2007 at 03:37:45AM -0400, Mingming Cao wrote: > > > This patch is on top of i_version_update_vfs. > > > The i_version field of the inode is set on inode creation and incremented > > > when the inode is being modified. > > > > Which is not what i_version is supposed to do. It'll get you tons of misses > > for NFSv3 filehandles that rely on the generation staying the same for the > > same file. Please add a new field for the NFSv4 sequence counter instead > > of making i_version unuseable. > > You are confusing i_generation (the instance of this inode number) with > i_version (whether this file has been modified)? Yes, sorry. Objection dropped.