From: Eric Sandeen Subject: Re: [PATCH] dir_index: error out instead of BUG on corrupt hash dir limit Date: Thu, 09 Aug 2007 17:41:42 -0500 Message-ID: <46BB9826.6040904@redhat.com> References: <46BB8830.3060009@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: ext4 development Return-path: Received: from mx1.redhat.com ([66.187.233.31]:51061 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751012AbXHIWlm (ORCPT ); Thu, 9 Aug 2007 18:41:42 -0400 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l79MffYp013213 for ; Thu, 9 Aug 2007 18:41:41 -0400 Received: from pobox-2.corp.redhat.com (pobox-2.corp.redhat.com [10.11.255.15]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l79Mffd1003061 for ; Thu, 9 Aug 2007 18:41:41 -0400 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox-2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l79MfdIk004832 for ; Thu, 9 Aug 2007 18:41:40 -0400 In-Reply-To: <46BB8830.3060009@redhat.com> Sender: linux-ext4-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org Eric Sandeen wrote: > A corrupt ondisk hash dir limit will trip an assert in dx_probe, > which calls BUG(). Instead, we can just issue the warning and > fail dx_probe like the other 3 tests just before it. Thanks > to aviro for suggesting this... BTW this type of corruption is apparently quite easily generated by using the binary windows-only ext driver at www.fs-driver.org.... -Eric