From: Andreas Dilger Subject: Re: [PATCH] dir_index: error out instead of BUG on corrupt hash dir limit Date: Fri, 10 Aug 2007 02:29:04 -0600 Message-ID: <20070810082904.GL6689@schatzie.adilger.int> References: <46BB8830.3060009@redhat.com> <46BB9826.6040904@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: ext4 development To: Eric Sandeen Return-path: Received: from mail.clusterfs.com ([74.0.229.162]:33230 "EHLO mail.clusterfs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758347AbXHJI3C (ORCPT ); Fri, 10 Aug 2007 04:29:02 -0400 Content-Disposition: inline In-Reply-To: <46BB9826.6040904@redhat.com> Sender: linux-ext4-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Aug 09, 2007 17:41 -0500, Eric Sandeen wrote: > Eric Sandeen wrote: > > A corrupt ondisk hash dir limit will trip an assert in dx_probe, > > which calls BUG(). Instead, we can just issue the warning and > > fail dx_probe like the other 3 tests just before it. Thanks > > to aviro for suggesting this... > > BTW this type of corruption is apparently quite easily generated by > using the binary windows-only ext driver at www.fs-driver.org.... I'd like to see the actual corruption, to find out why the hash-type check didn't find it. If it is because LDISKFS_DX_HASH_LEGACY hash type is zero, I think we can disable that hash type, and people will just have to run "e2fsck -fD" to reindex to a new type. This hasn't been on for a long, long time. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc.