From: Eric Sandeen Subject: Re: [PATCH] dir_index: error out instead of BUG on corrupt hash dir limit Date: Fri, 10 Aug 2007 11:08:01 -0500 Message-ID: <46BC8D61.9080400@redhat.com> References: <46BB8830.3060009@redhat.com> <46BB9826.6040904@redhat.com> <20070810082904.GL6689@schatzie.adilger.int> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: ext4 development To: Andreas Dilger Return-path: Received: from mx1.redhat.com ([66.187.233.31]:55733 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S940644AbXHJQIF (ORCPT ); Fri, 10 Aug 2007 12:08:05 -0400 In-Reply-To: <20070810082904.GL6689@schatzie.adilger.int> Sender: linux-ext4-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org Andreas Dilger wrote: > On Aug 09, 2007 17:41 -0500, Eric Sandeen wrote: >> Eric Sandeen wrote: >>> A corrupt ondisk hash dir limit will trip an assert in dx_probe, >>> which calls BUG(). Instead, we can just issue the warning and >>> fail dx_probe like the other 3 tests just before it. Thanks >>> to aviro for suggesting this... >> BTW this type of corruption is apparently quite easily generated by >> using the binary windows-only ext driver at www.fs-driver.org.... > > I'd like to see the actual corruption, to find out why the hash-type > check didn't find it. If it is because LDISKFS_DX_HASH_LEGACY hash > type is zero, I think we can disable that hash type, and people will > just have to run "e2fsck -fD" to reindex to a new type. This hasn't > been on for a long, long time. So far I haven't been able to find it in any of the images provided. We may have to dual-boot windows & run the crummy driver for a while to track it down, if we care enough. Which reminds me, what do you think of the wording in the ext3_warning I added - is "corruption" appropriate? The other warnings aren't quite so stark... hmm maybe we should add "have you been running a binary-only driver for windows?" :) -Eric