From: Mingming Cao Subject: [RFC 2/2] JBD: blocks reservation fix for large block support Date: Fri, 31 Aug 2007 17:12:21 -0700 Message-ID: <1188605541.3837.53.camel@localhost.localdomain> References: <20070828190551.415127746@sgi.com> <20070828190735.292638294@sgi.com> <1188432669.3799.35.camel@localhost.localdomain> <1188434857.3799.76.camel@localhost.localdomain> Reply-To: cmm@us.ibm.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: adilger@clusterfs.com, sho@tnes.nec.co.jp, linux-kernel@vger.kernel.org, clameter@sgi.com, linux-fsdevel@vger.kernel.org To: ext4 development Return-path: In-Reply-To: <1188434857.3799.76.camel@localhost.localdomain> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org The blocks per page could be less or quals to 1 with the large block support in VM. The patch fixed the way to calculate the number of blocks to reserve in journal in the case blocksize > pagesize. Signed-off-by: Mingming Cao Index: my2.6/fs/jbd/journal.c =================================================================== --- my2.6.orig/fs/jbd/journal.c 2007-08-31 13:27:16.000000000 -0700 +++ my2.6/fs/jbd/journal.c 2007-08-31 13:28:18.000000000 -0700 @@ -1611,7 +1611,12 @@ void journal_ack_err(journal_t *journal) int journal_blocks_per_page(struct inode *inode) { - return 1 << (PAGE_CACHE_SHIFT - inode->i_sb->s_blocksize_bits); + int bits = PAGE_CACHE_SHIFT - inode->i_sb->s_blocksize_bits; + + if (bits > 0) + return 1 << bits; + else + return 1; } /* Index: my2.6/fs/jbd2/journal.c =================================================================== --- my2.6.orig/fs/jbd2/journal.c 2007-08-31 13:32:21.000000000 -0700 +++ my2.6/fs/jbd2/journal.c 2007-08-31 13:32:30.000000000 -0700 @@ -1612,7 +1612,12 @@ void jbd2_journal_ack_err(journal_t *jou int jbd2_journal_blocks_per_page(struct inode *inode) { - return 1 << (PAGE_CACHE_SHIFT - inode->i_sb->s_blocksize_bits); + int bits = PAGE_CACHE_SHIFT - inode->i_sb->s_blocksize_bits; + + if (bits > 0) + return 1 << bits; + else + return 1; } /*