From: Christoph Hellwig Subject: Re: [RFC 1/2] JBD: slab management support for large block(>8k) Date: Sun, 2 Sep 2007 16:28:01 +0100 Message-ID: <20070902152801.GA19962@infradead.org> References: <20070828190551.415127746@sgi.com> <20070828190735.292638294@sgi.com> <1188432669.3799.35.camel@localhost.localdomain> <1188434857.3799.76.camel@localhost.localdomain> <1188605538.3837.51.camel@localhost.localdomain> <20070901183922.GA12907@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Mingming Cao , linux-fsdevel@vger.kernel.org, adilger@clusterfs.com, sho@tnes.nec.co.jp, ext4 development , linux-kernel@vger.kernel.org To: Christoph Lameter Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:57888 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757782AbXIBP2J (ORCPT ); Sun, 2 Sep 2007 11:28:09 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Sun, Sep 02, 2007 at 04:40:21AM -0700, Christoph Lameter wrote: > On Sat, 1 Sep 2007, Christoph Hellwig wrote: > > > On Fri, Aug 31, 2007 at 05:12:18PM -0700, Mingming Cao wrote: > > > >From clameter: > > > Teach jbd/jbd2 slab management to support >8k block size. Without this, it refused to mount on >8k ext3. > > > > > > But the real fix is to kill this code. We can't send down slab pages > > down the block layer without breaking iscsi or aoe. And this code is > > only used in so rare cases that all the normal testing won't hit it. > > Very bad combination. > > We are doing what you describe right now. So the current code is broken? Yes.