From: Mingming Cao <cmm@us.ibm.com>
Subject: Re: Sparse endian issues with patches.
Date: Wed, 12 Sep 2007 17:36:31 -0700
Message-ID: <1189643792.11977.2.camel@localhost.localdomain>
References: <46E81867.1000606@linux.vnet.ibm.com>
	 <20070913003258.GR5377@schatzie.adilger.int>
Reply-To: cmm@us.ibm.com
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	valerie.clement@bull.net, linux-ext4 <linux-ext4@vger.kernel.org>
To: Andreas Dilger <adilger@clusterfs.com>
In-Reply-To: <20070913003258.GR5377@schatzie.adilger.int>
Sender: linux-ext4-owner@vger.kernel.org

On Wed, 2007-09-12 at 18:32 -0600, Andreas Dilger wrote:
> On Sep 12, 2007  22:18 +0530, Aneesh Kumar K.V wrote:
> > Attaching below patch that fix the sparse warning for ext4.
> 
> It would be good to also fix the "raw" access of split 48-bit and 64-bit
> fields as I previously sent to the list.  A new typedef for these fields
> (on disk) would ensure that they are not accessed directly and give
> compiler warnings if new patches don't have the right macro usage.
> 
> > -				if (mnt_count != sbi->s_es->s_mnt_count) {
> > +				if (mnt_count != le16_to_cpu(sbi->s_es->s_mnt_count)) {
> 
> That overflows 80 columns, as do several other lines.
> > 
> 

checkpatch.pl should catched this... The version in ext4-patch queue
should be clean now.


> Cheers, Andreas
> --
> Andreas Dilger
> Principal Software Engineer
> Cluster File Systems, Inc.
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html