From: Eric Sandeen Subject: Re: [PATCH e2fsprogs] - ignore bind mounts in fsck Date: Thu, 20 Sep 2007 09:31:56 -0500 Message-ID: <46F2845C.2010000@redhat.com> References: <46F1847E.6080400@redhat.com> <20070919204249.GH25497@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: ext4 development To: Theodore Tso Return-path: Received: from mx1.redhat.com ([66.187.233.31]:59226 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754756AbXITOcA (ORCPT ); Thu, 20 Sep 2007 10:32:00 -0400 In-Reply-To: <20070919204249.GH25497@thunk.org> Sender: linux-ext4-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org Theodore Tso wrote: > On Wed, Sep 19, 2007 at 03:20:14PM -0500, Eric Sandeen wrote: >> An entry like this in /etc/fstab: >> >> /foo /bar ext3 bind,defaults 1 3 >> >> will stop boot, as fsck.ext3 tries to check it and fails: >> >> e2fsck 1.40.2 (12-Jul-2007) >> fsck.ext3: Is a directory while trying to open /foo >> >> The superblock could not be read or does not describe a correct ext2 >> filesystem. ... >> >> Granted, asking for fsck of a bind mount in the fstab is a bit odd, >> but it doesn't seem like it should stop the boot process if you make >> this mistake. > > That's fair, but note that the dump number and fsck pass number really > should be zero in the fstab entry. i.e., it really should be "0 0", > or just plain ommitted. Agreed. If you think fsck shouldn't silently cope with this mistake, and instead punish the user for it (it is what they asked for, after all), I'm ok with that too. I'm willing to close my end as NOTABUG if you don't want to take this patch. :) (FWIW, this is RH bug #151533) -Eric