From: akpm@linux-foundation.org Subject: + ext3-lighten-up-resize-transaction-requirements-checkpatch-fixes.patch added to -mm tree Date: Thu, 04 Oct 2007 12:27:23 -0700 Message-ID: <200710041927.l94JRNpg025103@imap1.linux-foundation.org> Reply-To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, adilger@clusterfs.com, linux-ext4@vger.kernel.org, sandeen@redhat.com To: mm-commits@vger.kernel.org Return-path: Sender: mm-commits-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org The patch titled ext3-lighten-up-resize-transaction-requirements-checkpatch-fixes has been added to the -mm tree. Its filename is ext3-lighten-up-resize-transaction-requirements-checkpatch-fixes.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: ext3-lighten-up-resize-transaction-requirements-checkpatch-fixes From: Andrew Morton ERROR: do not use assignment in if condition #58: FILE: fs/ext3/resize.c:173: + if ((err = ext3_journal_restart(handle, EXT3_MAX_TRANS_DATA))) ERROR: use tabs not spaces #60: FILE: fs/ext3/resize.c:175: +^I$ ERROR: do not use assignment in if condition #60: FILE: fs/ext3/resize.c:175: + if ((err = ext3_journal_get_write_access(handle, bh))) ERROR: use tabs not spaces #62: FILE: fs/ext3/resize.c:177: $ ERROR: do not use assignment in if condition #87: FILE: fs/ext3/resize.c:233: + if ((err = extend_or_restart_transaction(handle, 1, bh))) ERROR: do not use assignment in if condition #97: FILE: fs/ext3/resize.c:261: + if ((err = extend_or_restart_transaction(handle, 1, bh))) ERROR: do not use assignment in if condition #108: FILE: fs/ext3/resize.c:286: + if ((err = extend_or_restart_transaction(handle, 1, bh))) ERROR: do not use assignment in if condition #119: FILE: fs/ext3/resize.c:298: + if ((err = extend_or_restart_transaction(handle, 2, bh))) Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Cc: Cc: Andreas Dilger Cc: Eric Sandeen Signed-off-by: Andrew Morton --- diff -puN fs/ext3/resize.c~ext3-lighten-up-resize-transaction-requirements-checkpatch-fixes fs/ext3/resize.c --- a/fs/ext3/resize.c~ext3-lighten-up-resize-transaction-requirements-checkpatch-fixes +++ a/fs/ext3/resize.c @@ -170,11 +170,13 @@ static int extend_or_restart_transaction if (err < 0) return err; if (err) { - if ((err = ext3_journal_restart(handle, EXT3_MAX_TRANS_DATA))) + err = ext3_journal_restart(handle, EXT3_MAX_TRANS_DATA); + if (err) return err; - if ((err = ext3_journal_get_write_access(handle, bh))) + err = ext3_journal_get_write_access(handle, bh); + if (err) return err; - } + } return 0; } @@ -230,7 +232,8 @@ static int setup_new_group_blocks(struct ext3_debug("update backup group %#04lx (+%d)\n", block, bit); - if ((err = extend_or_restart_transaction(handle, 1, bh))) + err = extend_or_restart_transaction(handle, 1, bh); + if (err) goto exit_bh; gdb = sb_getblk(sb, block); @@ -258,7 +261,8 @@ static int setup_new_group_blocks(struct ext3_debug("clear reserved block %#04lx (+%d)\n", block, bit); - if ((err = extend_or_restart_transaction(handle, 1, bh))) + err = extend_or_restart_transaction(handle, 1, bh); + if (err) goto exit_bh; if (IS_ERR(gdb = bclean(handle, sb, block))) { @@ -283,7 +287,8 @@ static int setup_new_group_blocks(struct ext3_debug("clear inode block %#04lx (+%d)\n", block, bit); - if ((err = extend_or_restart_transaction(handle, 1, bh))) + err = extend_or_restart_transaction(handle, 1, bh); + if (err) goto exit_bh; if (IS_ERR(it = bclean(handle, sb, block))) { @@ -295,7 +300,8 @@ static int setup_new_group_blocks(struct ext3_set_bit(bit, bh->b_data); } - if ((err = extend_or_restart_transaction(handle, 2, bh))) + err = extend_or_restart_transaction(handle, 2, bh); + if (err) goto exit_bh; mark_bitmap_end(input->blocks_count, EXT3_BLOCKS_PER_GROUP(sb), _ Patches currently in -mm which might be from akpm@linux-foundation.org are fix-timer_stats-printout-of-events-sec.patch slow-down-printk-during-boot.patch acpi-add-reboot-mechanism.patch acpi-suppress-uninitialized-var-warning.patch git-alsa.patch working-3d-dri-intel-agpko-resume-for-i815-chip.patch git-arm.patch git-dvb.patch git-hwmon-fixup.patch git-infiniband.patch infiniband-work-around-gcc-slub-problem.patch git-input.patch git-input-fixup.patch adbhid-produce-all-capslock-key-events.patch console-keyboard-events-and-accessibility.patch first-stab-at-elantech-touchpad-driver-for-26226-testers.patch git-jg-misc-fix.patch git-jg-warning-fixes.patch git-kbuild.patch git-kbuild-fixup.patch git-kvm.patch git-libata-all.patch ide-arm-hack.patch git-mips.patch git-mmc.patch git-mmc-fixup2.patch mmc-fix-gregkh-driver-driver-core-change-add_uevent_var-to-use-a-struct.patch gregkh-driver-driver-core-change-add_uevent_var-to-use-a-struct-vs-git-mmc.patch git-mtd.patch git-mtd-vs-powerpc.patch git-net.patch git-net-fixup.patch git-net-more-bustage.patch ipgc-doesnt-compile-with-with-config_highmem64g.patch git-net-sctp-hack.patch forcedeth-power-down-phy-when-interface-is-down.patch git-net-vs-git-nfs.patch git-nfs-vs-git-unionfs.patch git-nfsd.patch git-nfsd-fixup.patch git-ocfs2.patch git-r8169-fixup.patch fix-ide-legacy-mode-resources.patch git-s390.patch git-sched.patch git-scsi-misc.patch git-scsi-misc-fixup.patch git-scsi-misc-arcmsr-build-fix.patch advansys-printk-fix.patch git-block.patch git-block-fixup.patch git-unionfs.patch fix-gregkh-usb-usb-sisusb2vga-convert-printk-to-dev_-macros.patch git-wireless.patch git-wireless-fixup.patch git-net-vs-git-wireless.patch git-wireless-vs-gregkh-driver-driver-core-change-add_uevent_var-to-use-a-struct.patch net-add-ath5k-wireless-driver-fix.patch revert-x86_64-mm-cpa-einval.patch fix-x86_64-mm-sched-clock-share.patch intel_cacheinfo-misc-section-annotation-fixes.patch x86_64-cleanup-apic-c.patch ich-force-hpet-ich7-or-later-quirk-to-force-detect-enable.patch ich-force-hpet-ich5-quirk-to-force-detect-enable.patch asm-i386-ioh-fix-constness.patch x86_64-check-and-enable-mmconfig-for-amd-family-10h-opteron.patch convert-cpu_sibling_map-to-a-per_cpu-data-array-ppc64-fix-2.patch git-xfs.patch optimize-x86-page-faults-like-all-other-achitectures-and-kill-notifier-cruft.patch git-kgdb-fixup.patch vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch sparsemem-record-when-a-section-has-a-valid-mem_map-fix.patch readahead-combine-file_ra_stateprev_index-prev_offset-into-prev_pos-fix.patch readahead-combine-file_ra_stateprev_index-prev_offset-into-prev_pos-fix-2.patch vm-dont-run-touch_buffer-during-buffercache-lookups.patch mm-use-pagevec-to-rotate-reclaimable-page-fix.patch fs-introduce-write_begin-write_end-and-perform_write-aops.patch git-nfs-vs-nfs-convert-to-new-aops.patch git-nfs-vs-nfs-convert-to-new-aops-fix.patch memoryless-nodes-introduce-mask-of-nodes-with-memory-fix.patch memoryless-nodes-fixup-uses-of-node_online_map-in-generic-code-fix-2.patch memoryless-nodes-fixup-uses-of-node_online_map-in-generic-code-fix-2-3.patch categorize-gfp-flags-fix.patch bias-the-location-of-pages-freed-for-min_free_kbytes-in-the-same-max_order_nr_pages-blocks.patch maps2-move-the-page-walker-code-to-lib.patch maps2-add-proc-pid-pagemap-interface.patch maps2-make-proc-pid-smaps-optional-under-config_embeddedpatch-fix.patch slub-slab-validation-move-tracking-information-alloc-outside-of-melstuff.patch hugetlbfs-read-support-fix.patch mm-mempolicyc-cleanups-fix.patch mm-bdi-init-hooks.patch mm-per-device-dirty-threshold-warning-fix.patch mm-dirty-balancing-for-tasks-warning-fix.patch slab-api-remove-useless-ctor-parameter-and-reorder-parameters-fix.patch slab-api-remove-useless-ctor-parameter-and-reorder-parameters-fix-2.patch slab-api-remove-useless-ctor-parameter-and-reorder-parameters-vs-unionfs.patch oom-change-all_unreclaimable-zone-member-to-flags-fix.patch oom-do-not-take-callback_mutex-fix.patch security-convert-lsm-into-a-static-interface-fix.patch security-convert-lsm-into-a-static-interface-fix-2.patch security-convert-lsm-into-a-static-interface-fix-unionfs.patch security-convert-lsm-into-a-static-interface-vs-fix-null-pointer-dereference-in-__vm_enough_memory.patch file-capabilities-clear-caps-cleanup-fix.patch capabilityh-remove-include-of-currenth.patch serial-turn-serial-console-suspend-a-boot-rather-than-compile-time-option-update.patch uml-clocksource-support-fix.patch uml-tickless-support-fix.patch softlockup-add-a-proc-tuning-parameter-fix.patch force-erroneous-inclusions-of-compiler-h-files-to-be-errors-fix.patch driver-for-the-atmel-on-chip-ssc-on-at32ap-and-at91-fix.patch add-kernel-notifierc-fix.patch do_sys_poll-simplify-playing-with-on-stack-data-fix.patch pcmcia-compactflash-driver-for-pa-semi-electra-boards.patch add-in-sunos-41x-compatible-mode-for-ufs-fix.patch core_pattern-fix-up-a-few-miscellaneous-bugs-fix.patch printk-add-interfaces-for-external-access-to-the-log-buffer-fix.patch deprecate-aout-elf-interpreters-fix.patch ext2-ext3-ext4-add-block-bitmap-validation-fix.patch pie-executable-randomization-fix-2.patch binfmt_flat-warning-fixes.patch console-events-and-accessibility-fix.patch track-accurate-idle-time-with-tick_schedidle_sleeptime-fix.patch send-quota-messages-via-netlink-fix-fix.patch i2o-fix-defined-but-not-used-build-warnings-fix.patch procfs-detect-duplicate-names-fix.patch procfs-detect-duplicate-names-fix-fix-2.patch keys-make-request_key-and-co-fundamentally-asynchronous-vs-git-mmc.patch reiserfs-workaround-for-dead-loop-in-finish_unfinished-fix.patch tty-expose-new-methods-needed-for-drivers-to-get-termios-fix.patch kernel-printkc-concerns-about-the-console-handover.patch userc-ifdef-mq_bytes-fix.patch jbd-config_jbd_debug-cannot-create-proc-entry-fix.patch binfmt_flat-minimum-support-for-the-blackfin-relocations-checkpatch-fixes.patch f_dupfd_cloexec-implementation-fix-2.patch ext3-lighten-up-resize-transaction-requirements-checkpatch-fixes.patch writeback-fix-time-ordering-of-the-per-superblock-dirty-inode-lists.patch writeback-fix-time-ordering-of-the-per-superblock-dirty-inode-lists-2.patch writeback-fix-time-ordering-of-the-per-superblock-dirty-inode-lists-3.patch writeback-fix-time-ordering-of-the-per-superblock-dirty-inode-lists-4.patch writeback-fix-comment-use-helper-function.patch writeback-fix-time-ordering-of-the-per-superblock-dirty-inode-lists-5.patch writeback-fix-time-ordering-of-the-per-superblock-dirty-inode-lists-6.patch writeback-fix-time-ordering-of-the-per-superblock-dirty-inode-lists-7.patch revert-faster-ext2_clear_inode.patch ext2-reservations-fix-for-percpu_counter-changes.patch ecryptfs-printk-warning-fixes.patch tdfxfb-mtrr-support-fix.patch fbdev-fb_create_modedb-non-static-int-first-=-1-fix.patch intel-fb-support-for-interlaced-video-modes.patch export-font_vga_8x16.patch drivers-video-pmag-ba-fbc-improve-diagnostics-fix.patch fbcon-logo-disable-logo-at-boot-fix.patch md-software-raid-autodetect-dev-list-not-array.patch intel-iommu-pci-generic-helper-function.patch intel-iommu-iova-allocation-and-management-routines.patch intel-iommu-intel-iommu-driver.patch intel-iommu-iommu-floppy-workaround.patch peterz-vs-ext4-mballoc-core.patch 64-bit-i_version-afs-fixes.patch r-o-bind-mounts-elevate-write-count-during-entire-ncp_ioctl-fix.patch slab-api-remove-useless-ctor-parameter-and-reorder-parameters-vs-revoke.patch revoke-wire-up-i386-system-calls.patch revoke-vs-git-block.patch task-containersv11-basic-task-container-framework-fix.patch task-containersv11-shared-container-subsystem-group-arrays-include-fix.patch add-containerstats-v3-fix.patch pid-namespaces-dynamic-kmem-cache-allocator-for-pid-namespaces-fix.patch pid-namespaces-define-is_global_init-and-is_container_init-fix.patch pid-namespaces-define-is_global_init-and-is_container_init-versus-x86_64-mm-i386-show-unhandled-signals-v3.patch fs-superc-use-list_for_each_entry-instead-of-list_for_each-fix.patch pid-namespaces-helpers-to-find-the-task-by-its-numerical-ids-fix.patch pid-namespaces-changes-to-show-virtual-ids-to-user-use-find_task_by_pid_ns-in-places-that-operate-with-virtual-fix.patch pid-namespaces-changes-to-show-virtual-ids-to-user-use-find_task_by_pid_ns-in-places-that-operate-with-virtual-fix-2.patch pid-namespaces-changes-to-show-virtual-ids-to-user-use-find_task_by_pid_ns-in-places-that-operate-with-virtual-fix-3.patch pid-namespaces-changes-to-show-virtual-ids-to-user-fix.patch memory-controller-memory-accounting-v7-fix.patch memory-controller-add-per-container-lru-and-reclaim-v7-fix.patch memory-controller-oom-handling-v7-vs-oom-killer-stuff.patch memory-controller-add-switch-to-control-what-type-of-pages-to-limit-v7-fix-2.patch memcontrol-move-oom-task-exclusion-to-tasklist-fix.patch remove-bits_to_type-macro-fix.patch use-helpers-to-obtain-task-pid-in-printks-drm-fix.patch hotplug-cpu-migrate-a-task-within-its-cpuset-fix.patch cpu-hotplug-avoid-hotadd-when-proper-possible_map-isnt-specified-checkpatch-fixes.patch powerpc-lock-bitops-fix.patch ipc-integrate-ipc_checkid-into-ipc_lock-fix.patch ipc-integrate-ipc_checkid-into-ipc_lock-fix-2.patch use-extended-crashkernel-command-line-on-i386.patch rework-proc-locks-via-seq_files-and-seq_list-helpers.patch hook-up-group-scheduler-with-control-groups-fix.patch linux-kernel-markers-checkpatch-fixes.patch linux-kernel-markers-samples-checkpatch-fixes.patch uninline-forkc-exitc-checkpatch-fixes.patch reiser4.patch git-block-vs-reiser4.patch git-nfsd-broke-reiser4.patch slab-api-remove-useless-ctor-parameter-and-reorder-parameters-vs-reiser4.patch page-owner-tracking-leak-detector.patch profile-likely-unlikely-macros-fix.patch check_dirty_inode_list.patch w1-build-fix.patch