From: Eric Sandeen Subject: Re: [PATCH] make mballoc history a config option Date: Fri, 01 Feb 2008 15:52:51 -0600 Message-ID: <47A394B3.8090908@redhat.com> References: <47A37F85.1050006@redhat.com> <47A38C4A.9000402@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: ext4 development Return-path: Received: from mx1.redhat.com ([66.187.233.31]:54306 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754431AbYBAVwx (ORCPT ); Fri, 1 Feb 2008 16:52:53 -0500 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m11LqqFx027569 for ; Fri, 1 Feb 2008 16:52:52 -0500 Received: from lacrosse.corp.redhat.com (lacrosse.corp.redhat.com [172.16.52.154]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m11Lqqhq021607 for ; Fri, 1 Feb 2008 16:52:52 -0500 Received: from neon.msp.redhat.com (neon.msp.redhat.com [10.15.80.10]) by lacrosse.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id m11LqpCm015948 for ; Fri, 1 Feb 2008 16:52:52 -0500 In-Reply-To: <47A38C4A.9000402@redhat.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: Eric Sandeen wrote: > Eric Sandeen wrote: > >> It's a bit shocking how much this matters to the size of >> ext4_mb_release_inode_pa etc; I've not yet found the >> reason why. > > Oh, well, duh - its' the big 108 byte allocation context on the > stack.... and if it's not used it gets optimized away. > > I think it's worth looking at allocating that one. Ok, hold off on that patch for now, sorry, looking at it more I think it should be done better. -Eric