From: akpm@linux-foundation.org Subject: - ext3-change-the-default-behaviour-on-error.patch removed from -mm tree Date: Wed, 06 Feb 2008 16:30:42 -0800 Message-ID: <200802070030.m170UNKs007384@imap1.linux-foundation.org> To: aneesh.kumar@linux.vnet.ibm.com, cebbert@redhat.com, davej@codemonkey.org.uk, jack@ucw.cz, linux-ext4@vger.kernel.org, sandeen@redhat.com, mm-commits@vger.kernel.org Return-path: Received: from smtp2.linux-foundation.org ([207.189.120.14]:33696 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934003AbYBGAq7 (ORCPT ); Wed, 6 Feb 2008 19:46:59 -0500 Sender: linux-ext4-owner@vger.kernel.org List-ID: The patch titled ext3: change the default behaviour on error has been removed from the -mm tree. Its filename was ext3-change-the-default-behaviour-on-error.patch This patch was dropped because it was merged into mainline or a subsystem tree The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: ext3: change the default behaviour on error From: "Aneesh Kumar K.V" ext3 file system was by default ignoring errors and continuing. This is not a good default as continuing on error could lead to file system corruption. Change the default to mark the file system readonly. Debian and ubuntu already does this as the default in their fstab. Signed-off-by: Aneesh Kumar K.V Cc: Cc: Eric Sandeen Cc: Jan Kara Cc: Dave Jones Cc: Chuck Ebbert Signed-off-by: Andrew Morton --- fs/ext3/super.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff -puN fs/ext3/super.c~ext3-change-the-default-behaviour-on-error fs/ext3/super.c --- a/fs/ext3/super.c~ext3-change-the-default-behaviour-on-error +++ a/fs/ext3/super.c @@ -575,16 +575,16 @@ static int ext3_show_options(struct seq_ le16_to_cpu(es->s_def_resgid) != EXT3_DEF_RESGID) { seq_printf(seq, ",resgid=%u", sbi->s_resgid); } - if (test_opt(sb, ERRORS_CONT)) { + if (test_opt(sb, ERRORS_RO)) { int def_errors = le16_to_cpu(es->s_errors); if (def_errors == EXT3_ERRORS_PANIC || - def_errors == EXT3_ERRORS_RO) { - seq_puts(seq, ",errors=continue"); + def_errors == EXT3_ERRORS_CONTINUE) { + seq_puts(seq, ",errors=remount-ro"); } } - if (test_opt(sb, ERRORS_RO)) - seq_puts(seq, ",errors=remount-ro"); + if (test_opt(sb, ERRORS_CONT)) + seq_puts(seq, ",errors=continue"); if (test_opt(sb, ERRORS_PANIC)) seq_puts(seq, ",errors=panic"); if (test_opt(sb, NO_UID32)) @@ -1583,10 +1583,10 @@ static int ext3_fill_super (struct super if (le16_to_cpu(sbi->s_es->s_errors) == EXT3_ERRORS_PANIC) set_opt(sbi->s_mount_opt, ERRORS_PANIC); - else if (le16_to_cpu(sbi->s_es->s_errors) == EXT3_ERRORS_RO) - set_opt(sbi->s_mount_opt, ERRORS_RO); - else + else if (le16_to_cpu(sbi->s_es->s_errors) == EXT3_ERRORS_CONTINUE) set_opt(sbi->s_mount_opt, ERRORS_CONT); + else + set_opt(sbi->s_mount_opt, ERRORS_RO); sbi->s_resuid = le16_to_cpu(es->s_def_resuid); sbi->s_resgid = le16_to_cpu(es->s_def_resgid); _ Patches currently in -mm which might be from aneesh.kumar@linux.vnet.ibm.com are origin.patch