From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Subject: Re: [PATCH] allocate struct ext4_allocation_context from a kmem
	cache to save stack space
Date: Fri, 08 Feb 2008 12:43:14 -0600
Message-ID: <1202496194.6852.15.camel@norville.austin.ibm.com>
References: <47A9E8CA.2070404@redhat.com>
	 <1202429513.3840.12.camel@localhost.localdomain>
	 <47ABAB29.2060300@redhat.com>
	 <1202434636.3840.25.camel@localhost.localdomain>
	 <47ABC00A.9080302@redhat.com>
	 <1202485537.6852.4.camel@norville.austin.ibm.com>
	 <1202488793.3936.4.camel@localhost.localdomain> <47AC8986.40409@redhat.com>
	 <1202495120.15315.3.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: Eric Sandeen <sandeen@redhat.com>,
	ext4 development <linux-ext4@vger.kernel.org>
To: cmm@us.ibm.com
In-Reply-To: <1202495120.15315.3.camel@localhost.localdomain>
Sender: linux-ext4-owner@vger.kernel.org


On Fri, 2008-02-08 at 10:25 -0800, Mingming Cao wrote:
> On Fri, 2008-02-08 at 10:55 -0600, Eric Sandeen wrote:
> > Mingming Cao wrote:
> > 
> > > printk could be removed...so as long as it builds fine. I had looked at
> > > the history yesterday and find this fix
> > > http://lists.openwall.net/linux-ext4/2007/10/10/2
> > > so I was under impression that the ifdefs was added to fix compile
> > > issue. I did not look more closely. Maybe that's not a issue any more.
> > 
> > I guess I should look into it.  For now let's just drop the #ifdef
> > removal, it's not related anyway.
> > 
> > Would you like me to send a fresh patch?
> > 
> ah...not necessary, I can edit the patch when merge it to the queue.
> Yes we could deal with the ifdef in a separate patch, maybe something
> like suggested by Shaggy.

The ifdef thing is sounding like a more global thing that could clean up
code elsewhere, so it's probably more of a kernel-janitors type thing.
I don't know if anyone wants to pursue it.  It's not a priority for me.

Shaggy
-- 
David Kleikamp
IBM Linux Technology Center