From: "Aneesh Kumar K.V" Subject: [PATCH] ext4: Don't mark the filesystem with errors if we fail to fallocate. Date: Mon, 18 Feb 2008 17:23:52 +0530 Message-ID: <1203335632-24426-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com> References: <1203335632-24426-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Cc: linux-ext4@vger.kernel.org, "Aneesh Kumar K.V" To: tytso@mit.edu, cmm@us.ibm.com Return-path: Received: from E23SMTP01.au.ibm.com ([202.81.18.162]:37287 "EHLO e23smtp01.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758116AbYBRLyB (ORCPT ); Mon, 18 Feb 2008 06:54:01 -0500 Received: from sd0109e.au.ibm.com (d23rh905.au.ibm.com [202.81.18.225]) by e23smtp01.au.ibm.com (8.13.1/8.13.1) with ESMTP id m1IBsi1G002331 for ; Mon, 18 Feb 2008 22:54:44 +1100 Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by sd0109e.au.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m1IBvX6O186812 for ; Mon, 18 Feb 2008 22:57:33 +1100 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m1IBrssE000593 for ; Mon, 18 Feb 2008 22:53:55 +1100 In-Reply-To: <1203335632-24426-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: IF we fail fallocate don't call ext4_error. Also don't hide errors from ext4_get_blocks_wrap Signed-off-by: Aneesh Kumar K.V --- fs/ext4/extents.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 5b22f71..bb01ac6 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -2653,13 +2653,14 @@ retry: ret = ext4_get_blocks_wrap(handle, inode, block, max_blocks, &map_bh, EXT4_CREATE_UNINITIALIZED_EXT, 0); - WARN_ON(ret <= 0); if (ret <= 0) { +#ifdef EXT4FS_DEBUG + WARN_ON(ret <= 0); ext4_error(inode->i_sb, "ext4_fallocate", "ext4_ext_get_blocks returned error: " "inode#%lu, block=%u, max_blocks=%lu", inode->i_ino, block, max_blocks); - ret = -EIO; +#endif ext4_mark_inode_dirty(handle, inode); ret2 = ext4_journal_stop(handle); break; -- 1.5.4.1.97.g40aab-dirty