From: Theodore Tso Subject: Re: [PATCH] e2fsprogs: error checking in blkid/devname.c Date: Fri, 22 Feb 2008 13:22:20 -0500 Message-ID: <20080222182220.GR20118@mit.edu> References: <47BDF6C9.8090009@redhat.com> <20080222131622.GK20118@mit.edu> <47BEE420.8030105@redhat.com> <20080222154404.GP20118@mit.edu> <47BEF575.40908@redhat.com> <20080222163331.GQ20118@mit.edu> <47BEFDD4.1040803@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: ext4 development , pspencer@fields.utoronto.ca To: Eric Sandeen Return-path: Received: from BISCAYNE-ONE-STATION.MIT.EDU ([18.7.7.80]:43838 "EHLO biscayne-one-station.mit.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754925AbYBVSXW (ORCPT ); Fri, 22 Feb 2008 13:23:22 -0500 Content-Disposition: inline In-Reply-To: <47BEFDD4.1040803@redhat.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Fri, Feb 22, 2008 at 10:52:36AM -0600, Eric Sandeen wrote: > Theodore Tso wrote: > > On Fri, Feb 22, 2008 at 10:16:53AM -0600, Eric Sandeen wrote: > >> From a quick chat with agk, it sounds like outright failure is > >> appropriate. Sounds like most of the calls fail for reasons like ENOMEM > >> (but it might be nice if it returned that, eh?) > > > > So the question then is why is it that Phillip was able to seeing > > failures when he was creating and deleting snapshots? > > > > I don't mind having blkid return a failure, but it may not fix > > Phillip's scenario which he listed in BZ #433857; yeah, he won't have > > a core dump, which is good, but it might mean that some or all of the > > dm volumes disappear from the blkid results. > > Maybe a device-mapper bug is in order :) Yep, especially if it can be easily reproduced. - Ted