From: Andreas Dilger Subject: Re: [RFC, PATCH 6/6] ext3: do not write to the disk when mounting a dirty read-only filesystem Date: Thu, 06 Mar 2008 00:17:34 -0700 Message-ID: <20080306071734.GN3616@webber.adilger.int> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7BIT Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Theodore Tso , sct@redhat.com, akpm@linux-foundation.org To: Duane Griffin Return-path: Received: from sca-es-mail-2.Sun.COM ([192.18.43.133]:51284 "EHLO sca-es-mail-2.sun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757207AbYCFHSP (ORCPT ); Thu, 6 Mar 2008 02:18:15 -0500 In-reply-to: Content-disposition: inline Sender: linux-ext4-owner@vger.kernel.org List-ID: On Mar 06, 2008 01:59 +0000, Duane Griffin wrote: > NOTE: For now I'm simply preventing filesystems requiring recovery from being > remounted read-write. This breaks booting with an uncleanly mounted root > filesystem! I was going to ask about this - not being able to remount rw is a serious problem because many users have only the root filesystem and this limitation basically prevents this patch from being landable. I'd suggest if the filesystem is going to be remounted read/write that the journal mapping be discarded and the journal replayed. Depending on how you do the mapping it may be necessary to invalidate all of the pages in the cache so that they don't reference the blocks in the journal. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc.